Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to delete collection at MemoryManager level in order to use the MemoryManager EventHandler. #65

Closed
VictorMuMo opened this issue Jan 25, 2024 · 1 comment · Fixed by #59, #61 or #66
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@VictorMuMo
Copy link
Contributor

The method RemoveOutdatedCollectionAsync in the EphemeralMemoryStoreHandler class calls the method DeleteCollectionAsync from the MemoryStore class that deletes an entire collection using the name of the collection. As the method is inside the MemoryStore object the event of deleting a collection is not getting raised at the MemoryManager level and would be good to take advantage of the EventHandler that the class already has. That's what we are proposing to create a method to delete a collection at the MemoryManager level.

@VictorMuMo VictorMuMo added the enhancement New feature or request label Jan 25, 2024
@VictorMuMo VictorMuMo self-assigned this Jan 25, 2024
@fjbelizon fjbelizon added the bug Something isn't working label Jan 25, 2024
@fjbelizon
Copy link
Contributor

fjbelizon commented Jan 25, 2024

I totally agree, this is a problem to be solved. The event handler managed by MemoryManager cannot know if a deletion has been made if the MemoryStore object is used directly. The correct thing to do is to have the MemoryManager object handle the deletion of collections and handle the associated event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants