Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PClub Task submission #1

Open
Enkryp opened this issue Aug 18, 2021 · 0 comments
Open

PClub Task submission #1

Enkryp opened this issue Aug 18, 2021 · 0 comments

Comments

@Enkryp
Copy link
Owner

Enkryp commented Aug 18, 2021

Sol to pclubiitk/student-search#26
Issue:

StudentName = 'First' + 'Middle' + 'Last'

If we search for any combination of these three strings, other than the one given in the original data, we don't get the desired results.

Example:
StudentName = 'Bhuvan Singla'
Search = 'Singla Bhuvan'

The problem can be resolved by modifying the filter of search_service to match the individual components ie. each space separated terms in "term" / search query to the names of students in json file.

eg: For "Som Tambe"; filter returns true since "Som" and "Tambe" are both present as substr in "Som Vishwas Tambe".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant