Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify debugging: Remove force refresh flag #139853

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Amplify debugging: Remove force refresh flag #139853

merged 1 commit into from
Dec 11, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Dec 11, 2024

Description

Our refresh flow checks for the current user, which we are thinking indirectly does a refresh of the tokens. We currently have a flag enabled to check Cognito directly for the user. Let's try removing that flag and see what it does with our local session (which will be cleared on logout).

Docs

Related ticket(s)

CMDCT-


How to test

  • Merge to main and see if auth flow works?

Notes

Guess


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Copy link

codeclimate bot commented Dec 11, 2024

Code Climate has analyzed commit 1c9c800 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

@ntsummers1 ntsummers1 marked this pull request as ready for review December 11, 2024 15:24
@ntsummers1 ntsummers1 merged commit 06dd1aa into main Dec 11, 2024
22 checks passed
@ntsummers1 ntsummers1 deleted the refresh-me-not branch December 11, 2024 15:24
ntsummers1 added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants