From 26961b73cf6073d8d2a91e5df9a37db5abf875e2 Mon Sep 17 00:00:00 2001 From: Valencia McMurray <46330428+Valencia2019@users.noreply.github.com> Date: Thu, 12 Oct 2023 09:48:26 -0400 Subject: [PATCH] removing duplicates and deprecated functions (#1390) and renaming steps that appeared to be duplicates, but were actually different test steps. Co-authored-by: bflynn-cms <99831795+bflynn-cms@users.noreply.github.com> --- ...shboard_Column_Picker_SPA_CMS.spec.feature | 25 +++--- ...board_Column_Picker_SPA_State.spec.feature | 18 ++-- ...oard_Column_Picker_Waiver_CMS.spec.feature | 14 ++-- ...rd_Column_Picker_Waiver_State.spec.feature | 14 ++-- .../cypress/e2e/Dashboard_Filter.spec.feature | 4 +- .../e2e/Dashboard_Filter_CMS.spec.feature | 4 +- .../e2e/Dashboard_Search_Bar.spec.feature | 12 +-- tests/cypress/cypress/e2e/common/steps.js | 40 ++------- .../support/pages/oneMacPackagePage.js | 83 +------------------ .../pages/oneMacSubmitNewWaiverActionPage.js | 3 - 10 files changed, 56 insertions(+), 161 deletions(-) diff --git a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_CMS.spec.feature b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_CMS.spec.feature index bc82945d1..cb3973cd5 100644 --- a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_CMS.spec.feature +++ b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_CMS.spec.feature @@ -8,7 +8,7 @@ Feature: Package Dashboard - SPA Tab Column Picker for CMS User Then verify show hide columns button exists Then verify SPA ID column exists Then verify type column exists - Then verify state column exists + Then Verify State Column Exists Then verify status column exists Then verify Initial Submission Date column exists Then verify Formal RAI Received column exists @@ -16,12 +16,12 @@ Feature: Package Dashboard - SPA Tab Column Picker for CMS User Then verify CPOC Name column does not exist Then click show hide columns button Then verify Formal RAI Received checkbox exists - Then verify Initial Submission Date exists - Then verify state exists - Then verify status exists - Then verify submitted by exists - Then verify type exists - Then verify CPOC Name exists + Then verify Initial Submission Date checkbox exists + Then verify state checkbox exists + Then verify status checkbox exists + Then verify submitted by checkbox exists + Then verify type checkbox exists + Then verify CPOC Name checkbox exists Then click show hide columns button Scenario: SPAs Tab - Uncheck all and verify SPA ID exists @@ -45,7 +45,7 @@ Feature: Package Dashboard - SPA Tab Column Picker for CMS User Then click the logout button Scenario: Verify state exists, click state from drop down, verify it no longer exists, click it again, verify it exists again. - Then verify state column exists + Then Verify State Column Exists Then click show hide columns button Then click state checkbox Then click show hide columns button @@ -53,7 +53,7 @@ Feature: Package Dashboard - SPA Tab Column Picker for CMS User Then click show hide columns button Then click state checkbox Then click show hide columns button - Then verify state column exists + Then Verify State Column Exists Then Click on My Account Then click the logout button @@ -89,11 +89,11 @@ Feature: Package Dashboard - SPA Tab Column Picker for CMS User Then click the logout button Scenario: Search with no results and verify error message is correct, verify columns are existing per selection on filter - Then type in search bar expiration status “pending” + Then search for "pending" Then verify Error message displayed should be No Results Found Then verify IDNumber column exists Then verify type column exists - Then verify state column exists + Then Verify State Column Exists Then verify Formal RAI Received column exists Then verify status column exists Then verify Initial Submission Date column exists @@ -107,9 +107,8 @@ Feature: Package Dashboard - SPA Tab Column Picker for CMS User Then click status checkbox Then click Formal RAI Received checkbox Then click show hide columns button - #Then type partial existing ID in search bar Then verify type column exists - Then verify state column exists + Then Verify State Column Exists Then verify the type on row one exists Then verify the state on row one exists Then click show hide columns button diff --git a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_State.spec.feature b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_State.spec.feature index 879d2fed2..fd10df2f6 100644 --- a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_State.spec.feature +++ b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_SPA_State.spec.feature @@ -17,13 +17,13 @@ Feature: Package Dashboard - SPA Tab Column Picker Then verify Formal RAI Received column exists Then click show hide columns button Then verify Formal RAI Received checkbox exists - Then verify Initial Submission Date exists - Then verify state exists - Then verify status exists - Then verify submitted by exists - Then verify type exists + Then verify Initial Submission Date checkbox exists + Then verify state checkbox exists + Then verify status checkbox exists + Then verify submitted by checkbox exists + Then verify type checkbox exists Then verify Formal RAI Received checkbox exists - Then verify CPOC Name exists + Then verify CPOC Name checkbox exists Then click show hide columns button Scenario: SPAs Tab - Uncheck all and verify SPA ID and actions exists @@ -52,7 +52,7 @@ Feature: Package Dashboard - SPA Tab Column Picker Then click show hide columns button Then click state checkbox Then click show hide columns button - Then verify state column exists + Then Verify State Column Exists Then click show hide columns button Then click state checkbox Then click show hide columns button @@ -91,7 +91,7 @@ Feature: Package Dashboard - SPA Tab Column Picker Then click the logout button Scenario: Search with no results and verify error message is correct, verify columns are existing per selection on filter - Then type in search bar expiration status “pending” + Then search for "pending" Then verify Error message displayed should be No Results Found Then verify IDNumber column exists Then verify type column exists @@ -113,7 +113,7 @@ Feature: Package Dashboard - SPA Tab Column Picker Then click state checkbox Then click show hide columns button Then verify type column exists - Then verify state column exists + Then Verify State Column Exists Then verify the type on row one exists Then verify the state on row one exists Then click show hide columns button diff --git a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_CMS.spec.feature b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_CMS.spec.feature index 84f6778e8..787de6890 100644 --- a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_CMS.spec.feature +++ b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_CMS.spec.feature @@ -9,7 +9,7 @@ Feature: Package Dashboard - Waiver Tab Column Picker for CMS User Then verify show hide columns button exists Then verify IDNumber column exists Then verify type column exists - Then verify state column exists + Then Verify State Column Exists Then verify Waiver Number column exists Then verify status column exists Then verify Initial Submission Date column exists @@ -18,12 +18,12 @@ Feature: Package Dashboard - Waiver Tab Column Picker for CMS User Then verify CPOC Name column does not exist Then click show hide columns button Then verify Formal RAI Received checkbox exists - Then verify state exists - Then verify status exists - Then verify Initial Submission Date exists - Then verify submitted by exists - Then verify type exists - Then verify CPOC Name exists + Then verify state checkbox exists + Then verify status checkbox exists + Then verify Initial Submission Date checkbox exists + Then verify submitted by checkbox exists + Then verify type checkbox exists + Then verify CPOC Name checkbox exists Then click show hide columns button Then Click on My Account Then click the logout button diff --git a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_State.spec.feature b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_State.spec.feature index f4e1ed52d..723ce1065 100644 --- a/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_State.spec.feature +++ b/tests/cypress/cypress/e2e/Dashboard_Column_Picker_Waiver_State.spec.feature @@ -19,12 +19,12 @@ Feature: Package Dashboard - Waiver Tab Column Picker Then verify CPOC Name column does not exist Then click show hide columns button Then verify Formal RAI Received checkbox exists - Then verify state exists - Then verify status exists - Then verify Initial Submission Date exists - Then verify submitted by exists - Then verify type exists - Then verify CPOC Name exists + Then verify state checkbox exists + Then verify status checkbox exists + Then verify Initial Submission Date checkbox exists + Then verify submitted by checkbox exists + Then verify type checkbox exists + Then verify CPOC Name checkbox exists Then click show hide columns button Then Click on My Account Then click the logout button @@ -69,7 +69,7 @@ Feature: Package Dashboard - Waiver Tab Column Picker Then click show hide columns button Then click state checkbox Then click show hide columns button - Then verify state column exists + Then Verify State Column Exists Then click show hide columns button Then click state checkbox Then click show hide columns button diff --git a/tests/cypress/cypress/e2e/Dashboard_Filter.spec.feature b/tests/cypress/cypress/e2e/Dashboard_Filter.spec.feature index d2953c008..90e777373 100644 --- a/tests/cypress/cypress/e2e/Dashboard_Filter.spec.feature +++ b/tests/cypress/cypress/e2e/Dashboard_Filter.spec.feature @@ -11,7 +11,7 @@ Feature: Package Dashboard - Filter Then verify Close Exists Then verify reset Exists Then verify state dropdown filter exists - Then verify Type Exists + Then verify type dropdown filter exists Then verify status DropDown Filter exists Then verify Initial Submission Date filter dropdown exists Then click on Initial Submission Date filter dropdown @@ -28,7 +28,7 @@ Feature: Package Dashboard - Filter Then verify Close Exists Then verify reset Exists Then verify state dropdown filter exists - Then verify Type Exists + Then verify type dropdown filter exists Then verify status DropDown Filter exists Then verify Initial Submission Date filter dropdown exists Then click on Initial Submission Date filter dropdown diff --git a/tests/cypress/cypress/e2e/Dashboard_Filter_CMS.spec.feature b/tests/cypress/cypress/e2e/Dashboard_Filter_CMS.spec.feature index 69a9b6fd6..725022a38 100644 --- a/tests/cypress/cypress/e2e/Dashboard_Filter_CMS.spec.feature +++ b/tests/cypress/cypress/e2e/Dashboard_Filter_CMS.spec.feature @@ -11,7 +11,7 @@ Feature: Package Dashboard - Filter Then verify Close Exists Then verify reset Exists Then verify state dropdown filter exists - Then verify Type Exists + Then verify type dropdown filter exists Then verify status DropDown Filter exists Then verify Initial Submission Date filter dropdown exists Then verify Formal RAI Received dropdown filter exists @@ -26,7 +26,7 @@ Feature: Package Dashboard - Filter Then verify Close Exists Then verify reset Exists Then verify state dropdown filter exists - Then verify Type Exists + Then verify type dropdown filter exists Then verify status DropDown Filter exists Then verify Initial Submission Date filter dropdown exists Then verify Formal RAI Received dropdown filter exists diff --git a/tests/cypress/cypress/e2e/Dashboard_Search_Bar.spec.feature b/tests/cypress/cypress/e2e/Dashboard_Search_Bar.spec.feature index e03491858..ea0ae312f 100644 --- a/tests/cypress/cypress/e2e/Dashboard_Search_Bar.spec.feature +++ b/tests/cypress/cypress/e2e/Dashboard_Search_Bar.spec.feature @@ -12,7 +12,7 @@ Feature: OY2-11149 Submission Dashboard - Search bar Given I am on Login Page When Clicking on Development Login When Login with state submitter user - Then type in search bar expiration status “pending” + Then search for "pending" Then verify Error message displayed should be No Results Found Then verify Error message details is displayed @@ -48,14 +48,14 @@ Feature: OY2-11149 Submission Dashboard - Search bar Then verify submission successful message in the alert bar Then search for Initial Waiver Number 2 with 12 Characters Then clear search bar - Then type in submitters name + Then search for "Angie Active" Then verify user exists with id number searched Scenario: Search existing user with Upper case Given I am on Login Page When Clicking on Development Login When Login with state submitter user - Then search existing user with all upper case + Then search for "ANGIE ACTIVE" Then verify user exists with id number searched @@ -63,7 +63,7 @@ Feature: OY2-11149 Submission Dashboard - Search bar Given I am on Login Page When Clicking on Development Login When Login with state submitter user - Then search existing user with dash + Then search for "-" Then verify user exists with id number searched Scenario: Search CPOC @@ -72,7 +72,7 @@ Feature: OY2-11149 Submission Dashboard - Search bar When Login with state submitter user Then click show hide columns button Then click CPOC Name checkbox - Then search for CPOC named Chester Tester + Then search for "Chester Tester" Then verify the CPOC searched for is Chester Tester in the first result Scenario: Log in with help desk user @@ -95,5 +95,5 @@ Feature: OY2-11149 Submission Dashboard - Search bar When Login with state submitter user Then verify search bar exists Then verify Search by Package ID, CPOC Name, or Submitter Name is displayed on top of search bar - Then search existing user with all upper case + Then search for "ANGIE ACTIVE" Then verify x in search bar exists to clear search and click it diff --git a/tests/cypress/cypress/e2e/common/steps.js b/tests/cypress/cypress/e2e/common/steps.js index 5aa88cbc1..f7541495a 100644 --- a/tests/cypress/cypress/e2e/common/steps.js +++ b/tests/cypress/cypress/e2e/common/steps.js @@ -1123,10 +1123,6 @@ Then( OneMacHomePage.verifyCMSBullet6Exists(); } ); - -Then("type in search bar expiration status “pending”", () => { - OneMacPackagePage.typePendingInSearchBar(); -}); Then("verify Error message displayed should be No Results Found", () => { OneMacPackagePage.noResultsFoundErrorMessage(); }); @@ -1138,15 +1134,6 @@ Then("verify user exists with id number searched", () => { Then("clear search bar", () => { OneMacPackagePage.clearSearchBar(); }); -Then("type in submitters name", () => { - OneMacPackagePage.typeSubmittersName(); -}); -Then("search existing user with all upper case", () => { - OneMacPackagePage.typeSubmittersNameAllUpperCase(); -}); -Then("search existing user with dash", () => { - OneMacPackagePage.typedashInSearchBar(); -}); Then("verify search bar exists", () => { OneMacPackagePage.verifySearchBarExists(); }); @@ -1183,7 +1170,7 @@ Then("verify Filter By Exists", () => { Then("verify Close Exists", () => { OneMacPackagePage.verifycloseButtonExists(); }); -Then("verify Type Exists", () => { +Then("verify type dropdown filter exists", () => { OneMacPackagePage.verifytypeDropDownExists(); }); Then("verify reset Exists", () => { @@ -1288,22 +1275,22 @@ Then("verify show hide columns button exists", () => { Then("click show hide columns button", () => { OneMacPackagePage.clickShowHideColumnsBTN(); }); -Then("verify Initial Submission Date exists", () => { +Then("verify Initial Submission Date checkbox exists", () => { OneMacPackagePage.verifycheckBoxInitialSubmissionDateExists(); }); -Then("verify state exists", () => { +Then("verify state checkbox exists", () => { OneMacPackagePage.verifycheckboxStateExists(); }); -Then("verify status exists", () => { +Then("verify status checkbox exists", () => { OneMacPackagePage.verifycheckBoxStatusExists(); }); -Then("verify submitted by exists", () => { +Then("verify submitted by checkbox exists", () => { OneMacPackagePage.verifycheckBoxSubmittedByExists(); }); -Then("verify type exists", () => { +Then("verify type checkbox exists", () => { OneMacPackagePage.verifycheckBoxTypeExists(); }); -Then("verify CPOC Name exists", () => { +Then("verify CPOC Name checkbox exists", () => { OneMacPackagePage.verifycheckBoxCPOCNameExists(); }); Then("verify Formal RAI Received checkbox exists", () => { @@ -1367,7 +1354,7 @@ Then("verify type column does not exist", () => { OneMacPackagePage.verifytypeColumnDoesNotExist(); }); Then("verify state column does not exist", () => { - OneMacPackagePage.verifystateColumnDoesNotExist(); + OneMacPackagePage.verifyStateColumnDoesNotExist(); }); Then("verify status column does not exist", () => { OneMacPackagePage.verifystatusColumnDoesNotExist(); @@ -1384,9 +1371,6 @@ Then("verify the type on row one exists", () => { Then("verify the type on row one is Medicaid SPA", () => { OneMacPackagePage.verifypackageRowOneTypeHasTextMedicaidSPA(); }); -Then("type partial existing ID in search bar", () => { - OneMacPackagePage.typePartialExistingID(); -}); Then("verify the state on row one exists", () => { OneMacPackagePage.verifypackageRowOneStateExists(); }); @@ -1611,14 +1595,6 @@ Then("search for {string}", (part) => { OneMacPackagePage.searchFor(part); cy.wait(1000); }); -Then("search for CPOC named Chester Tester", () => { - OneMacPackagePage.searchFor("Chester Tester"); - cy.wait(1000); -}); -Then("search for Appendix K number", () => { - OneMacPackagePage.searchFor("MD-10330.R00.12"); - cy.wait(1000); -}); Then("verify that Request a Role Change button exists", () => { OneMacUserManagmentPage.verifyRequestARoleChangeBtnExists(); }); diff --git a/tests/cypress/support/pages/oneMacPackagePage.js b/tests/cypress/support/pages/oneMacPackagePage.js index 57f8215de..537ce567a 100644 --- a/tests/cypress/support/pages/oneMacPackagePage.js +++ b/tests/cypress/support/pages/oneMacPackagePage.js @@ -123,7 +123,6 @@ const checkBoxType = "//span[contains(text(),'Type')]"; const checkboxCPOCName = "//span[contains(text(),'CPOC Name')]"; const IDNumberColumn = "#componentIdColHeader"; const typeColumn = "#componentTypeColHeader"; -const stateColumn = "#territoryColHeader"; const statusColumn = "#packageStatusColHeader"; const initialSubmissionDateColumn = "#submissionTimestampColHeader"; const submittedByColumn = "#submitterColHeader"; @@ -239,10 +238,6 @@ export class oneMacPackagePage { cy.xpath(expirationDateColumnHeader).should("be.visible"); } - typePendingInSearchBar() { - cy.get(searchbar).type("pending"); - } - noResultsFoundErrorMessage() { cy.xpath(noResultsFound).contains("No Results Found"); } @@ -265,9 +260,6 @@ export class oneMacPackagePage { typeSubmittersNameAllUpperCase() { cy.get(searchbar).type("ANGIE ACTIVE"); } - typedashInSearchBar() { - cy.get(searchbar).type("-"); - } verifySearchBarExists() { cy.get(searchbar).should("be.visible"); } @@ -545,9 +537,6 @@ export class oneMacPackagePage { verifytypeColumnExists() { cy.get(typeColumn).should("be.visible"); } - verifystateColumnExists() { - cy.get(stateColumn).should("be.visible"); - } verifystatusColumnExists() { cy.get(statusColumn).should("be.visible"); } @@ -574,8 +563,8 @@ export class oneMacPackagePage { verifytypeColumnDoesNotExist() { cy.get(typeColumn).should("not.exist"); } - verifystateColumnDoesNotExist() { - cy.get(stateColumn).should("not.exist"); + verifyStateColumnDoesNotExist() { + cy.get(stateColumnHeader).should("not.exist"); } verifystatusColumnDoesNotExist() { cy.get(statusColumn).should("not.exist"); @@ -604,9 +593,6 @@ export class oneMacPackagePage { verifypackageRowOneTypeHasTextMedicaidSPA() { cy.get(packageRowOneType).should("have.text", "Medicaid SPA"); } - typePartialExistingID() { - cy.get(searchbar).type("MD-13"); - } checkforApprovedIsNotClickable() { cy.xpath(Approved).children("button").should("be.disabled"); } @@ -787,70 +773,7 @@ export class oneMacPackagePage { searchFor(part) { cy.get(searchbar).type(part); } - verifyFirstParentRowExpanderExists() { - cy.xpath(parentRowExpander).should("be.visible"); - } - verifyTheNextRowIsNotAChild() { - cy.get(rowTwo).should("not.have.class", "child-row-expanded"); - } - clickFirstParentRowExpander() { - cy.xpath(parentRowExpander).not(":disabled").click(); - } - verifyTheNextRowIsAChild() { - cy.get(rowTwo).should("have.class", "child-row-expanded"); - } - verifyAllChildrenStartWith(part) { - cy.xpath(childRows).each(($el) => { - cy.wrap($el).find("td:nth-of-type(2)").should("contain.text", part); - }); - } - verifyWaiverNumberColumnExistsForChild() { - cy.get(packageRowTwoID).should("be.visible"); - } - verifytypeColumnExistsForChild() { - cy.get(packageRowTwoType).should("be.visible"); - } - verifystateColumnExistsForChild() { - cy.get(packageRowTwoState).should("be.visible"); - } - verify90thDayColumnExistsForChild() { - cy.get(packageRowTwo90thDay).should("be.visible"); - } - verifystatusColumnExistsForChild() { - cy.get(packageRowOneType).should("be.visible"); - } - verifyInitialSubmissionDateColumnExistsForChild() { - cy.get(packageRowTwoInitialSubmissionDate).should("be.visible"); - } - verifysubmittedByColumnExistsForChild() { - cy.get(packageRowTwoSubmittedBy).should("be.visible"); - } - verifyactionsColumnExistsForChild() { - cy.get(packageRowTwoActions).should("be.visible"); - } - clickActionsColumnForChild() { - cy.get(packageRowTwoActions).scrollIntoView().click(); - } - verifyChildActionsBtnIsDisabled() { - cy.get(packageRowTwoActions) - .scrollIntoView() - .children("button") - .first() - .should("be.disabled"); - } - clickActionsBtnForTempExtensionChild() { - cy.xpath(childRows) - .filter(":contains('Temporary Extension')") - .then(($el) => { - cy.wrap($el).find("button").first().scrollIntoView().click(); - }); - } - verifyFirstParentRowExpanderIsDisabled() { - cy.xpath(parentRowExpander).should("be.disabled"); - } - verifyFirstParentRowExpanderIsNotDisabled() { - cy.xpath(parentRowExpander).should("not.be.disabled"); - } + clickWithdrawPackageBtn() { cy.xpath(withdrawPackageBtn) .filter(":visible") diff --git a/tests/cypress/support/pages/oneMacSubmitNewWaiverActionPage.js b/tests/cypress/support/pages/oneMacSubmitNewWaiverActionPage.js index 2ed8ee0e9..b808b6873 100644 --- a/tests/cypress/support/pages/oneMacSubmitNewWaiverActionPage.js +++ b/tests/cypress/support/pages/oneMacSubmitNewWaiverActionPage.js @@ -1,5 +1,4 @@ const newWaiverNumberInputBox = "#componentId"; -const actionTypeDropDown = "#action-type"; const newErrMsgForWaiverNumber = "#componentIdStatusMsg0"; const errorMsgPart2 = "#componentIdStatusMsg1"; const waiverAuthority = "//h3[text()='Waiver Authority']"; @@ -12,7 +11,6 @@ const capitatedSpreadsheetFile = "//td[div[contains(text(),'1915(b) Comprehensive (Capitated) Waiver Cost Effectiveness Spreadsheets')]]"; const fileUpload1 = "#uploader-input-0"; const fileUpload2 = "#uploader-input-1"; -const commentsInputBox = "#field_2"; const additionalInfoTextarea = "#additional-information"; const existingWaiverNumber = "MD-22005.R00.00"; const whatIsMyInitialWaiverNumberLink = @@ -152,7 +150,6 @@ export class oneMacSubmitNewWaiverActionPage { } }); } - setProposedEffectiveDateThreeMonthsAway() { var futureDate = caculate3MonthsInFuture(); cy.get(proposedEffectiveDate).type(futureDate);