Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update demo code in readme to work with angularjs 1.8 #143

Open
ajtag opened this issue Oct 25, 2022 · 1 comment
Open

update demo code in readme to work with angularjs 1.8 #143

ajtag opened this issue Oct 25, 2022 · 1 comment

Comments

@ajtag
Copy link

ajtag commented Oct 25, 2022

according to
https://knowledge.exlibrisgroup.com/Primo/Product_Materials/Announcements/Preparing_for_the_Upgrade_to_Angular_1.8_in_Primo%2F%2FPrimo_VE

it looks like the demo code in the README will not be valid after the November2022 update
@rschwab
Copy link

rschwab commented Jan 11, 2023

Good catch! Yes, specifically the code on this page needs to use the onInit() method.

@rschwab rschwab mentioned this issue Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rschwab @ajtag