-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive unit tests and docs for LHN item presence #52031
Comments
Triggered auto assignment to @RachCHopkins ( |
Expensify slack thread for convenience: https://expensify.slack.com/archives/C05LX9D6E07/p1727967763482779 |
Eep! 4 days overdue now. Issues have feelings too... |
Still overdue 6 days?! Let's take care of this! |
8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
12 days overdue now... This issue's end is nigh! |
This issue has not been updated in over 14 days. eroding to Weekly issue. |
We are chugging along on these |
in progress |
Problem
LHN items have a historical record of rendering inconsistencies & regressions that lead us to a recurring question of “Why is this in my LHN?”.
There are multiple factors determining which reports should be displayed including report’s type, participants, status, specific conditions such as being pinned, having violations, or being archived which makes it easy to accidentally break this pipeline.
Solution
Implement a comprehensive unit test suite & docs around
shouldReportBeInOptionList
that focuses on clearly defined scenarios for report visibility. This will help us increase confidence and make sure on the CI level that no regressions in this area make it to the production environment which is not something we can guarantee ourselves right now. Here are some sample scenarios we can assert:Should show the report
slack thread: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1727967763482779
The text was updated successfully, but these errors were encountered: