Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive unit tests and docs for LHN item presence #52031

Closed
OlimpiaZurek opened this issue Nov 5, 2024 · 10 comments
Closed

Comprehensive unit tests and docs for LHN item presence #52031

OlimpiaZurek opened this issue Nov 5, 2024 · 10 comments
Assignees
Labels
Planning Changes still in the thought process Weekly KSv2

Comments

@OlimpiaZurek
Copy link
Contributor

Problem
LHN items have a historical record of rendering inconsistencies & regressions that lead us to a recurring question of “Why is this in my LHN?”.
There are multiple factors determining which reports should be displayed including report’s type, participants, status, specific conditions such as being pinned, having violations, or being archived which makes it easy to accidentally break this pipeline.

Solution
Implement a comprehensive unit test suite & docs around shouldReportBeInOptionList that focuses on clearly defined scenarios for report visibility. This will help us increase confidence and make sure on the CI level that no regressions in this area make it to the production environment which is not something we can guarantee ourselves right now. Here are some sample scenarios we can assert:

Should show the report

  • is expense report with outstanding violations and the report is not reimbursed
  • is currently viewing
  • has valid draft comment in the report
  • Is a self DM report
  • is marked it as pinned
  • is in focus mode and the report is unread
  • is in default mode and the report is archived

slack thread: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1727967763482779

@OlimpiaZurek OlimpiaZurek added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@RachCHopkins
Copy link
Contributor

Expensify slack thread for convenience: https://expensify.slack.com/archives/C05LX9D6E07/p1727967763482779

@mountiny mountiny added Planning Changes still in the thought process and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 5, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Nov 15, 2024

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Nov 19, 2024

12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot removed the Daily KSv2 label Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

This issue has not been updated in over 14 days. eroding to Weekly issue.

@mountiny
Copy link
Contributor

mountiny commented Dec 2, 2024

We are chugging along on these

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2024
@mountiny
Copy link
Contributor

in progress

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@mountiny
Copy link
Contributor

This was for tracking and the last issue open is this one #52034 and the PR for it was just merged so I think we can close this one and consider it concluded #53745

@melvin-bot melvin-bot bot removed the Overdue label Dec 26, 2024
@github-project-automation github-project-automation bot moved this from HIGH to Done in [#whatsnext] #quality Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Planning Changes still in the thought process Weekly KSv2
Projects
Development

No branches or pull requests

3 participants