[HOLD for payment 2024-12-07] [HOLD for payment 2024-12-05] Android - Group - Start group button on confirmation page has extra bottom margin

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Device navigation is buttons instead of swipe gestures.

1. Launch ND or hybrid app.
2. Go to FAB > Start chat.
3. Tap Add to group next to any user.
4. Tap Next.

Expected Result:

Start group button on confirmation page will not have extra bottom margin

Actual Result:

Start group button on confirmation page has extra bottom margin.

This issue is not reproducible if device navigation uses swipe gestures.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6677725_1732691351761.Screen_Recording_20241127_150606.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MariaHCD]

Seems like there are a few deploy blockers related to the way buttons appear in Android. Clarifying in the issue linked above ^

[twisterdotcom]

Should we close this or HOLD on #53161 (comment)?

[MariaHCD]

Assigning @kirillzyusko since this also looks to be a regression from the edge-to-edge PR

[MariaHCD]

@kirillzyusko could you comment here so I can assign you?

[kirillzyusko]

Sure, feel free to assign me on this issue 👋

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[kirillzyusko]

Can we assign @chrispader on this?

He is working on this ticket at the moment

[chrispader]

commenting for assignment!

[mountiny]

Confirmed this was fixed in the 67-8

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Android edge-to-edge related inset/padding issues #53223

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

• @chrispader does not require payment (Contractor)
• @kirillzyusko does not require payment (Contractor)

[melvin-bot]

@mountiny @twisterdotcom @chrispader / @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

Payment for @allroundexperts handled elsewhere.

No regression test needed as it was a challenging new feature flag for android and these small styling issues are temporary

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Android edge-to-edge related inset/padding issues #53223

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

• @chrispader does not require payment (Contractor)
• @kirillzyusko does not require payment (Contractor)

[melvin-bot]

@mountiny @twisterdotcom @chrispader / @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]