Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-12-12 #53978

Closed
55 tasks done
github-actions bot opened this issue Dec 12, 2024 · 14 comments
Closed
55 tasks done

Deploy Checklist: New Expensify 2024-12-12 #53978

github-actions bot opened this issue Dec 12, 2024 · 14 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Release Version: 9.0.75-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@luacmartins luacmartins added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 12, 2024
@luacmartins luacmartins self-assigned this Dec 12, 2024
@luacmartins luacmartins added the Daily KSv2 label Dec 12, 2024
@mvtglobally
Copy link

@luacmartins for some reason the following 2 PR links lead to 404. Do we need to QA them?

#53747
#51940

@izarutskaya
Copy link

Regression is at 45% completed.

PRs:
#51018 - Blocked for now #51018 (comment)
#51517 - found issue #51517 (comment) Pending mWeb, Desktop, Android
#52221 - Pending validation mWeb, Android and iOS
#51940, #53747 - Blocked for now. PR links lead to 404 page
#52556 - Pending validation on Android
#52803 - pending validation on mWeb, Desktop, Android, iOs
#53661 - Failing with #53661 (comment)

DB:
#53986
#53987
#53988
#53989
#53990
#53991
#53992
#53995

@isagoico
Copy link

The following PRs were deleted and are currently being investigated to check what happened:

Going to post in #qa to check if we should check them off or if we should wait till there's an answer from GH.

@joekaufmanexpensify
Copy link
Contributor

Checked off #53863

@Julesssss
Copy link
Contributor

Checked off #53987

@mvtglobally
Copy link

Android build issue is resolved. Team is working on the Android slots now too.

Regression is at 80% completed.

@luacmartins
Copy link
Contributor

@mvtglobally are you still having issues loading these PRs?

@isagoico what do you mean they were deleted? #53978 (comment)

@luacmartins
Copy link
Contributor

Ah just saw the thread in Slack. It seems like GH fixed the issue

@tgolen
Copy link
Contributor

tgolen commented Dec 12, 2024

I closed #54063 because it sounds to me like it is expected behavior.

@mvtglobally
Copy link

Regression is at 2% left

PRs:
#53111 - Is failing with #53111. Repro in PROD. Checking off
#53420 - Pending validation on mWeb and Android
#53661 - is failing with #53987, #53999
#53722 - is failing with KI #52999. Checking off
#53755 - Pending validation on Desktop
#53861 (comment)

DB:
#53995
#54066

@marcaaron
Copy link
Contributor

I'm going to check off #53861 because it doesn't seem like it can be reliably QA'd and is covering a fairly extreme edge case.

@mvtglobally
Copy link

mvtglobally commented Dec 13, 2024

Regression is completed

Checking CP and last PR

@Julesssss
Copy link
Contributor

Checked off #53995 (comment) as a pass, and the associated CP.

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

10 participants