New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Drive.FindAngleToSpeaker has limited range of return values #56

Closed

dlpond917 opened this issue Feb 10, 2024 · 0 comments · Fixed by #57

Collaborator

dlpond917 commented Feb 10, 2024

Two problems:

Amber and I changed this to use atan2 instead of atan. atan2 is not the right function to use when calculating angles of a right triangle; switch back to atan.
The function needs to take the robot heading into account. If the robot is facing left instead of right, the calculated heading will swing it around to the right again.

nmp2965 linked a pull request

that will close this issue

fixed turn to angle #57

Merged

amb2127 closed this as completed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment