Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to set quoting #43

Open
d33tah opened this issue Sep 10, 2023 · 2 comments
Open

Add a way to set quoting #43

d33tah opened this issue Sep 10, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@d33tah
Copy link

d33tah commented Sep 10, 2023

I just found the following in the code:

    let mut writer = csv::WriterBuilder::new()
        .quote_style(csv::QuoteStyle::Never)
        .delimiter(b',')
        .from_writer(out);

Why is QuoteStyle::Never there? Items containing commas break the writer by making CSV unreadable. Any chance you could expose some interface to override that?

@FabioBatSilva FabioBatSilva added the help wanted Extra attention is needed label Sep 13, 2023
@FabioBatSilva
Copy link
Owner

That sounds like a good idea..
Can't think of a good reason why that is there..

@d33tah
Copy link
Author

d33tah commented Feb 29, 2024

Would you be OK with just getting rid of this line, changing the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants