Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11 support #103

Closed
2 of 3 tasks
modmuss50 opened this issue Jan 25, 2019 · 8 comments
Closed
2 of 3 tasks

Java 11 support #103

modmuss50 opened this issue Jan 25, 2019 · 8 comments
Assignees

Comments

@modmuss50
Copy link
Member

modmuss50 commented Jan 25, 2019

A few things need to be done to support J11

  • Update the syntax pane library to 1.2.0 to fix Crash log Tested to work

  • Fix the decompiler using URLClassPath Crash log

  • Dracula causes warnings, Link to issue

Not the end of the world right now, but might be something to keep in mind. There may be more issues as well.

@Ansraer
Copy link

Ansraer commented Feb 11, 2019

I am currently looking into making engima compatible with java 1.9 since the buggy dpi scaling in 1.8 makes enigma unuseable on a 4k monitor.
I have run into a bit of a dead end right now since enigma uses a fork of Procyon-compiler tools (http://maven.modmuss50.me/org/bitbucket/mstrobel/procyon-compilertools/) that appears to be horribly out of date (a fix for the URLClassPath was committed to the original Procyon about a year ago). @modmuss50 Could you please either upload your fork to a github repo or simply publish a updated version to your maven?

@modmuss50
Copy link
Member Author

We can look into it, I know the compiler tools that I host has 1 patch (somewhere on bit bucket irrc)

@Ansraer
Copy link

Ansraer commented Feb 11, 2019

Thanks, I would greatly appreciate that.

@asiekierka
Copy link
Contributor

Maybe you should just migrate the Procyon repo to here, seeing as it's not really maintained.

MORE FORKS \o/

@modmuss50
Copy link
Member Author

I think I have found the version of procyon we use,

https://bitbucket.org/cuchaz/procyon/commits/all

There are a number of commits from cuchaz that may or may not be relevant still.

@asiekierka
Copy link
Contributor

That's actually quite outdated compared to mainline!

The only relevant commit for us is https://bitbucket.org/cuchaz/procyon/commits/a8cc9faf9b17bc4de56297c0873d6ab48f106d98 , I'm pretty sure. I'd just fork upstream to FabricMC and cherry-pick this, and hope it works.

@asiekierka asiekierka self-assigned this Feb 12, 2019
@asiekierka
Copy link
Contributor

Working on this.

@asiekierka
Copy link
Contributor

There is an issue with Unsafe.defineClass being missing in Java 11+ specifically, but I'm pretty sure it does not affect Enigma, merely the standalone decompiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants