Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FabricRecipeProvider doesn't wrap identifiers of advancements' recipe rewards FabricRecipeProvider#getRecipeIdentifier #4176

Open
boyonk913 opened this issue Oct 20, 2024 · 1 comment
Open

FabricRecipeProvider doesn't wrap identifiers of advancements' recipe rewards FabricRecipeProvider#getRecipeIdentifier #4176

boyonk913 opened this issue Oct 20, 2024 · 1 comment

Comments

@boyonk913
Copy link

boyonk913 commented Oct 20, 2024 •
edited
Loading

FabricRecipeProvider does not wrap the ID references to the recipe with FabricRecipePRovider#getRecipeIdentifier in the advancement's rewards.recipes.

This means that when FabricRecipePRovider#getRecipeIdentifier returns anything different than the argument passed in, the recipe will not be rewarded to the player when the advancement is gained.
@maityyy
Copy link
Contributor

maityyy commented Dec 13, 2024

#4252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boyonk913 @maityyy