Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemModelManager#hasHandAnimationOnSwap should respect the FabricItem#allowComponentsUpdateAnimation return value #4293

Open
haykam821 opened this issue Dec 10, 2024 · 0 comments
Open

ItemModelManager#hasHandAnimationOnSwap should respect the FabricItem#allowComponentsUpdateAnimation return value #4293

haykam821 opened this issue Dec 10, 2024 · 0 comments

Comments

@haykam821
Copy link
Contributor

The recently-added hand_animation_on_swap field is similar to the FabricItem#allowComponentsUpdateAnimation method. They should use a similar implementation, with care being taken to ensure FabricItem#allowComponentsUpdateAnimation is limited to item stacks with the same item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haykam821