Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Frame rate' is inconsistently spelled as one word #4000

Open
haykam821 opened this issue Sep 25, 2024 · 5 comments · May be fixed by #4047
Open

'Frame rate' is inconsistently spelled as one word #4000

haykam821 opened this issue Sep 25, 2024 · 5 comments · May be fixed by #4047

Comments

@haykam821
Copy link
Contributor

Both the 'frame rate' and 'framerate' spellings are used. Note that the options screen uses the text 'framerate', though that may not be the correct spelling.

@Octol1ttle
Copy link
Contributor

Both the 'frame rate' and 'framerate' spellings are used. Note that the options screen uses the text 'framerate', though that may not be the correct spelling.

The Wiktionary says that "frame rate" is the correct spelling, so which one do we use?

@modmuss50
Copy link
Member

Going by https://www.minecraft.net/en-us/article/save-energy-with-the-frames-per-second-limiter-feature "framerate" is used, seems like a reasonable source to follow to me.

@Octol1ttle
Copy link
Contributor

Maybe it's worth just switching all usages of framerate to fps, since latter seems to be used much more frequently?
image

@modmuss50
Copy link
Member

No, I dont think FPS and framerate are the same thing. FPS Is a unit of framerate. There might well be places where FPS could be used, but check before blindly replacing it everywhere.

@Octol1ttle
Copy link
Contributor

No, I dont think FPS and framerate are the same thing. FPS Is a unit of framerate. There might well be places where FPS could be used, but check before blindly replacing it everywhere.

they are the same thing in the context of Minecraft, as Minecraft always uses FPS to measure framerate. both instances of "framerate" being used in Yarn refer to FPS (MAX_FRAMERATE is used in the max framerate slider, which is measured in FPS, and frameRateSamples gets populated with MinecraftClient#currentFps)

@Octol1ttle Octol1ttle linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants