Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Please use a direct link to an image like https://imgur.com/{id} or https://i.imgur.com/{id}.png #953

Open
cellularmitosis opened this issue Nov 6, 2024 · 2 comments

Comments

@cellularmitosis
Copy link

Not sure what I'm doing wrong, but I keep getting this error, despite using an imgur URL (https://imgur.com/a/UbFrF8Z, or https://i.imgur.com/1QyjcMF.jpg)

@dazemc
Copy link
Contributor

dazemc commented Nov 8, 2024

Parsing issue, you can bypass by removing the preceding 'i' and '.png' from your link if you don't want to wait for the pr to be merged. Interesting though, the error says .png but imgur supports more than png. Maybe the regex should take this into consideration..... It looks like imgur handles the redirect for that itself so it actually doesn't matter. For example, https://imgur.com/1QyjcMF.png, https://imgur.com/1QyjcMF, and https://imgur.com/1QyjcMF.jpg

All resolve to the same resource.

There I just changed the PR to accept all imgur extension types

@FactorioBlueprints
Copy link
Owner

@dazemc fixed the issue in the Create page. It's still a problem in the Edit page, so I'll leave this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants