-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FairModule::AddSensitiveVolume
searches volume set twice
#1495
Labels
Comments
1 task
This was referenced Mar 4, 2024
Merged
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
386912e introduced a double linear search of the volume on
vList
inFairModule::AddSensitiveVolume
:FairVolumeList::addVolume
Possible fix involves changing the error behaviour of
FairVolumeList::addVolume
to return the failure to add to the caller, e.g. by returning a pointer to the added volume (which isnullptr
in case of not adding it).The text was updated successfully, but these errors were encountered: