Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Waterworld Documentation bug - food color #1227

Open
1 task done
yidilozdemir opened this issue Aug 7, 2024 · 0 comments
Open
1 task done

[Bug Report] Waterworld Documentation bug - food color #1227

yidilozdemir opened this issue Aug 7, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@yidilozdemir
Copy link

yidilozdemir commented Aug 7, 2024

In the SISL/Waterworld section, there is a mismatch between the documentation and the code on the color of the objects.

"For example, by default there are 5 agents (purple), 5 food targets (red) and 10 poison targets (green)."

But in waterworld_models, the rgb colors of food targets -- evaders correspond to green (ln 67)

class Evaders(MovingObject):
    def __init__(self, x, y, vx, vy, radius=0.03, collision_type=2, max_speed=100, nutrition=2):
        super().__init__(x, y, radius=radius)

        self.body.velocity = vx, vy

        self.color = (145, 250, 116)

and color of poison target corresponds to red (ln 88)

class Poisons(MovingObject):
    def __init__(
        self, x, y, vx, vy, radius=0.015 * 3 / 4, collision_type=3, max_speed=100
    ):
        super().__init__(x, y, radius=radius)

        self.body.velocity = vx, vy

        self.color = (238, 116, 106)

Did I get that right? Should I make a PR to fix the docs?

  • I have checked that there is no similar issue in the repo
@yidilozdemir yidilozdemir added the bug Something isn't working label Aug 7, 2024
@David-GERARD David-GERARD self-assigned this Nov 22, 2024
@David-GERARD David-GERARD added this to the 1.24.4 release milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants