-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AvroSchemaGenerator: logicalType(s) never set for non-date classes #535
Comments
This is probably the state of things: logical type support was added a while ago via #283 and that's probably the extent. Which other types would make sense? As usual, PRs woud be welcome -- while I likely don't have time to work on this myself, I try my best to help anyone who wants to contribute. |
Hi -- actually I thought maybe it was a bug because there's even older closed issues/conversations about this, around 2018. I couldn't quite make sense of it but it seemed like it had been added in the past. Ends with "I think this is probably obsoleted by later work, closing.". The other types that would make sense are "decimal" and "uuid" (there may be more as per spec, but I don't think so). |
@credmond My recollection (which may be incomplete for sure) is that date/time types were added but not much else. Adding more types should be straight-forward by someone digging in code (with guidance from earlier work, mainly #283). Thank you for reporting omission in any case. |
Ok yes, looking bit deeper, #133 would have added support for To add support, one place to look is where tests are, under |
Note: open issues wrt logical types: |
Sort of related: #536 will add support for |
logicalTypes doesn't appear to be set for anything other than dates.
Output:
MyClass:
The text was updated successfully, but these errors were encountered: