Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PWAs report incorrect URL #1446

Open
7 of 9 tasks
Octelly opened this issue Sep 22, 2024 · 2 comments
Open
7 of 9 tasks

[Bug]: PWAs report incorrect URL #1446

Octelly opened this issue Sep 22, 2024 · 2 comments
Labels
bug Something isn't working P4 Basically, we don't work on it, but contributions of patches are welcomed.

Comments

@Octelly
Copy link

Octelly commented Sep 22, 2024

Pre-Submission Checklist

  • I have checked the existing/closed issues to ensure this issue has not already been reported.
  • I am using the latest supported version of the browser.
  • I have tried disabling all browser extensions/add-ons to rule out interference from these.
  • I have tried clearing the browser cache and cookies.
  • I have checked with a new profile and the issue still occurs.
  • I have provided detailed step-by-step instructions on how to reproduce the issue.
  • I have included relevant screenshots or console outputs.
  • I have checked that this problem is not occurring in the latest version of Firefox ESR.
  • This issue is specific to this browser and does not occur in other browsers.

Bug Summary

PWAs report incorrect URLs to extensions.
image
In this example, Bitwarden is showing me GitHub logins on Feishin, even though it's supposed to be showing my Navidrome login
Screenshot_20240922_172131
and does so when Feishin is not open as a PWA
image

Reproduction Steps

  1. Open a website as a PWA
  2. Try to use an extension that uses related API calls (not an extension dev)

Expected Behavior

Same behavior as when site is not open as a PWA

Actual Behavior

See Bug Summary

Screenshots

See Bug Summary

Browser Version

11.18.1 (64-bit)

Operating System

Arch Linux (Tested on NixOS Unstable as well)

Additional Context

I am aware that PWAs are still experimental and I am not expecting this issue to be resolved quickly. Just reporting it because I have not found it among reported issues and it does degrade my experience of using this otherwise wonderful browser.

@Octelly Octelly added the bug Something isn't working label Sep 22, 2024
@github-actions github-actions bot added P5 Developers do not respond, only patches are welcome unconfirmed Developer has not yet confirmed. labels Sep 22, 2024
@surapunoyousei
Copy link
Member

Until 11.7.0 Floorp was reporting the correct URL for extensions in the PWA window, but due to problems I changed it to report the URL in the main window.

I do not plan to fix this at this time as I believe the ad blocker and other features are working fine.

The reason for this is that the extension that creates tab groups has a problem that deletes pages that are open in the PWA window.

@surapunoyousei surapunoyousei added P4 Basically, we don't work on it, but contributions of patches are welcomed. and removed P5 Developers do not respond, only patches are welcome unconfirmed Developer has not yet confirmed. labels Sep 22, 2024
@Octelly
Copy link
Author

Octelly commented Sep 24, 2024

@surapunoyousei Thank you for the explanation. If this is the case, I'll just wait for PWAs to become more mature and try to deal with the issue in other ways in the mean time. Thank you for your time and effort.

(I would like to however keep the issue open until it is actually resolve if you don't mind - could be useful to others and I'll get notified once the newest Floorp version resolves it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P4 Basically, we don't work on it, but contributions of patches are welcomed.
Projects
None yet
Development

No branches or pull requests

2 participants