Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tab hover thumbnails break once any Web Panel is activated. #1451

Open
6 of 9 tasks
guigirl42 opened this issue Sep 27, 2024 · 15 comments
Open
6 of 9 tasks

[Bug]: Tab hover thumbnails break once any Web Panel is activated. #1451

guigirl42 opened this issue Sep 27, 2024 · 15 comments
Labels
bug Something isn't working P4 Basically, we don't work on it, but contributions of patches are welcomed.

Comments

@guigirl42
Copy link

Pre-Submission Checklist

  • I have checked the existing/closed issues to ensure this issue has not already been reported.
  • I am using the latest supported version of the browser.
  • I have tried disabling all browser extensions/add-ons to rule out interference from these.
  • I have tried clearing the browser cache and cookies.
  • I have checked with a new profile and the issue still occurs.
  • I have provided detailed step-by-step instructions on how to reproduce the issue.
  • I have included relevant screenshots or console outputs.
  • I have checked that this problem is not occurring in the latest version of Firefox ESR.
  • This issue is specific to this browser and does not occur in other browsers.

Bug Summary

Using Floorp's native vertical tabs on LHS, with tab hover thumbnail previews enabled [per below], each loaded but unfocused tab correctly displays its thumbnail preview when hovered-over with the mouse pointer... unless & until... the user then activates any of her sidebar Web Panels. Doing so instantly breaks the thumbnail function for the remainder of the browser session, ie, the only way to get them working again is to relaunch Floorp. However, that workaround ofc fails the moment the user needs to use more of her Web Panels.

Reproduction Steps

  1. In about:config set browser.tabs.hoverPreview.enabled to True.
  2. Open several normal tabs & activate / load them.
  3. For each of the unfocused tabs, hover the mouse pointer at/over them, & observe the small tab thumbnail preview image that appears.
  4. Open any of the user's existing Web Panels.
  5. For the next step it does not matter if the Web Panels remain open or closed.
  6. Repeat Step 3, except this time NO tab thumbnail preview image appears.
  7. Close Floorp then relaunch it, note the thumbnail preview images work again... until opening any Web Panels.

Expected Behavior

All tab hover thumbnail preview images should remain available regardless of any other browser activity, including using the Web Panels.

Actual Behavior

All tab hover thumbnail preview images break after using the Web Panels.

Screenshots

N/A.

Browser Version

Version 11.18.1 (64-bit) | Firefox: 128.3.0

Operating System

ArchLinux KDEPlasma Wayland.

Additional Context

The bug also occurs in a virgin profile, not only my normal daily profile.

@guigirl42 guigirl42 added the bug Something isn't working label Sep 27, 2024
@github-actions github-actions bot added P5 Developers do not respond, only patches are welcome unconfirmed Developer has not yet confirmed. labels Sep 27, 2024
@surapunoyousei surapunoyousei added P4 Basically, we don't work on it, but contributions of patches are welcomed. and removed P5 Developers do not respond, only patches are welcome unconfirmed Developer has not yet confirmed. labels Sep 27, 2024
@surapunoyousei
Copy link
Member

We do not intend to address this issue in Floorp 11 at this time. It is a feature that is not yet officially supported.

We will fix it in Floorp 12.

@surapunoyousei
Copy link
Member

We are currently investigating the cause.

@surapunoyousei
Copy link
Member

image

I edited the code here and was able to fix it, but I don't think I can fix it right away.

@guigirl42
Copy link
Author

don't think I can fix it right away

I assume that means, as you told me before, we users won't have it working until

in Floorp 12

🤷‍♀️

@surapunoyousei
Copy link
Member

It is dangerous to deploy immediately because the release is the day after tomorrow.

@guigirl42
Copy link
Author

Oh, fwiw, i was not trying to rush you, but only for me to understand the situation.

the release is the day after tomorrow

Do you mean something like 11.18.1 ---> 11.18.2 or 11.19.0?

@surapunoyousei
Copy link
Member

surapunoyousei commented Sep 27, 2024

My mistake to write "Floorp 12".

I will distribute a fix around 11.20.0.

Thanks for your cooperation.

@guigirl42
Copy link
Author

Oh, sorry, another question. Previous versions of Floorp have twice had breakage of the popup URLs in the status bar, when Web Panels were used [it's all working fine now]. Hopefully the fix you've made for these hover thumbnails won't have re-broken those URLs... i ask coz it seems a common link is the Web Panels.

@surapunoyousei
Copy link
Member

My reasoning is that it will not affect them.

The fix is located in a different component of Firefox and no bugs were seen during debugging.

@guigirl42
Copy link
Author

It seems that you did manage to include the fix in v11.19.0, & in my testing so far it does indeed seem to be solved now. Thank you.


Unfortunately though, Floorp remains unable to be used as my full-time default daily browser, because the problems of #1416 (comment) remain present, & severely degrade the user experience.

@surapunoyousei
Copy link
Member

I recommended to use Tabliss extension instead of Floorp Home

@guigirl42
Copy link
Author

I recommended to use Tabliss extension instead of Floorp Home

I'm sorry, but i don't understand your post; how does it relate to this Issue? 🤷‍♀️

@surapunoyousei
Copy link
Member

If there is a problem with the new tab, using an extension that replaces the new tab is an alternative

@guigirl42
Copy link
Author

If there is a problem with the new tab, using an extension that replaces the new tab is an alternative

Huh? I think your last two posts are in the wrong thread. THIS thread is Tab hover thumbnails break once any Web Panel is activated ... nothing at all to do with new tabs or home screens.

@surapunoyousei
Copy link
Member

Unfortunately though, Floorp remains unable to be used as my full-time default daily browser, because the problems of #1416 (comment) remain present, & severely degrade the user experience.

I have mentioned this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P4 Basically, we don't work on it, but contributions of patches are welcomed.
Projects
None yet
Development

No branches or pull requests

2 participants