Fix calendar handling of pre-1970 birthdates #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
The bug occurred when a contact was created in 'Fossify Contacts' with a birthdate prior to 1970 and saved with the 'Phone Storage (not visible by other apps)' setting. Before the changes, when Calendar synced with the storage, the birth year would automatically default to 1970. After the changes, this behavior has been removed. See screenshot
Profile of a contact who will be 100 years old on May 3, 2024
Before Changes : Event on May 3, 2024: the contact celebrates its 54th anniversary (2024-1970).
After Changes : Event on May 3, 2024: the contact celebrates its 100th anniversary (2024-1924).
Fixes the following issue(s)
Acknowledgement