Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: skipCountdown doens't work at all #3954

Closed
2 tasks done
Starexify opened this issue Dec 25, 2024 · 3 comments
Closed
2 tasks done

Bug Report: skipCountdown doens't work at all #3954

Starexify opened this issue Dec 25, 2024 · 3 comments
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.

Comments

@Starexify
Copy link

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Newgrounds (Web/HTML5)

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

I try create a new song in FNF and I want to skip the countdown when the song is loaded and just start the song, I tried using both events onSongLoaded and onCountdownStart and called Countdown.skipCountdown(); but no use, it still plays the Countdown for some reason (Yes other classes work, only the skipCountdown doesnt for some reason)

Steps to Reproduce

  1. Create a ScriptedSong
  2. Try Countdown.skipCountdown(); onSongLoaded and/or onCountdownStart
  3. Doesn't work
@Starexify Starexify added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Dec 25, 2024
@AbnormalPoof
Copy link
Contributor

It does work, but you have to put it in a FlxTimer for some reason:

override function onCountdownStart(event) {
  super.onCountdownStart(event);
  new FlxTimer().start(0.0001, function(tmr:FlxTimer) {
     Countdown.skipCountdown();
  });
}

@lemz1
Copy link
Contributor

lemz1 commented Dec 26, 2024

it might not be the best solution, but you could do something like this:

override function onCountdownStart(event) {
  super.onCountdownStart(event);
  event.eventCanceled = true;
  PlayState.instance.isInCountdown = true;
  Countdown.skipCountdown();
}

by doing it like this you dont have to use a timer, which is a bit better in my opinion

@Starexify
Copy link
Author

Thanks, it seems to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

3 participants