Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readability through OOP and basic documentation #76

Open
Moosems opened this issue Jan 22, 2023 · 52 comments
Open

Add readability through OOP and basic documentation #76

Moosems opened this issue Jan 22, 2023 · 52 comments

Comments

@Moosems
Copy link
Member

Moosems commented Jan 22, 2023

No description provided.

@not-nef
Copy link
Member

not-nef commented Jan 23, 2023

no oop.

@Moosems
Copy link
Member Author

Moosems commented Jan 23, 2023

Why not?

@im-coder-lg
Copy link
Member

@not-nef OOP gives more clarity. Last time I checked, many people used OOP to have more neatness and control over Python. We can help you with this, you know. I don't use much OOP, but I can promise to test the code logics that uses OOP code here.

@not-nef
Copy link
Member

not-nef commented Jan 23, 2023

im against oop because i dont understand it AT ALL. So if we switch to oop with all the classes and shit i wont be able to maintain this project no more

@sumeshir26
Copy link
Member

Well its your wish but in the long run It is easier to maintain with classes since everything is seperate

@Moosems
Copy link
Member Author

Moosems commented Jan 23, 2023

im against oop because i dont understand it AT ALL. So if we switch to oop with all the classes and shit i wont be able to maintain this project no more

Then learn it. You don't learn by not doing. You learn by failing and changing

@Moosems
Copy link
Member Author

Moosems commented Jan 23, 2023

Well its your wish but in the long run It is easier to maintain with classes since everything is seperate

Plus it keeps everything self contained and makes tracking down problems easier

@not-nef
Copy link
Member

not-nef commented Jan 23, 2023

yeah ok but ill leave the transition to you because you seem to understand it better

@Moosems
Copy link
Member Author

Moosems commented Jan 23, 2023

Ok 👍. I can document it if that helps

@Moosems
Copy link
Member Author

Moosems commented Jan 23, 2023

not-nef I actually used to code just like you do but I promise that if you learn oop it will change your world

@not-nef
Copy link
Member

not-nef commented Jan 23, 2023

yeah but for now im gonna focus on some other projects

@im-coder-lg
Copy link
Member

Guys I have some ideas in mind. Like a weather app using Gtk4+ and PyQt or something for Linux and Tukaan for Windows and Mac. Anyone interested? We will be using a lot of APIs, mainly from OpenWeatherMap.

@im-coder-lg
Copy link
Member

Maybe there we could use OOP. And scratch GTK4+ and all that, we'll just use Tukaan. Or mainstream Tkinter with sv-ttk.

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Normally it's better to stick with one GUI ToolKit however I am more than interested in this weather app

@sumeshir26
Copy link
Member

@im-coder-lg Im out cuz i got no time for coding, and all my coding time these days is spent on Jou... The app seems interesting tho...

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

@im-coder-lg definetely in if we use tkinter

@im-coder-lg
Copy link
Member

im-coder-lg commented Jan 24, 2023

Okay guys, and @sumeshir26 I get it. We will do it during May though, to get the most time.

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

@im-coder-lg Im out cuz i got no time for coding, and all my coding time these days is spent on Jou... The app seems interesting tho...

Remember that Jou is still in early development and subject to big changes. It also isn't very strong in any categories yet

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

better learn c tbh

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Okay guys, and @sumeshir26 I get it. We will do it during May though, to get the most time.

You want to create the repo to start? Also can we change the file structure from a src type folder to a more open one? I can set up a pyinstaller build action so we can test our app upon push

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Not-nef you know c?

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

uuuuhm... sure, but python is my strong suit

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Do we want to try a messaging thing again? IRC is pretty good for development

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

did i miss something? what messenger

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

I remember a while back that ee tried finding a messaging service so we could talk faster

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

whats wrong about github, its not like were in a rush

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Well it's easier for debugging when you can quickly respond and chat long amounts that others don't need to read through to help

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Me and Akuli chat using irc.libera.chat on ##learnpython (Try his mantaray client)

@sumeshir26
Copy link
Member

@Futura-Py/reviewers Shall I create the repo? Need a name

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

weather (Futura Weather)

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

I guess I'm part of Futura now?

@sumeshir26
Copy link
Member

OKay

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

I guess I'm part of Futura now?

sure

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Nice 👍

@sumeshir26
Copy link
Member

So what framework should we use? Tukaan, Tkinter, GTK+, Something of C, or what?

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Tkinter? It's great for a prototype but not great once it gets really nice

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

What exactly is the plan/design for it? @im-coder-lg This was your plan so maybe you choose?

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

The best framework ever is pyqt. Its hard to learn but if you know it you can basically write fluent apps

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

You learned it Nef? I've wanted to get into it for a long time but never cared to

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

no. not yet. but i desperately want to. just need to get my ass up

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Let's do it then

@sumeshir26
Copy link
Member

You know what, I'm working on this as well. Lemme push everything else aside.

@sumeshir26
Copy link
Member

sumeshir26 commented Jan 24, 2023

I guess time to watch a PyQt6 tutorial...
And do you guys wanna use PySide6 or PyQt6

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

PyQt6 personally

@im-coder-lg
Copy link
Member

Isn't Qt used for KDE? Look, I just want to make this simple and intuitive for the common user. We'll start with a barebones CLI version of Weather to look into the packaging methods, and then we will work on the GUI. Personally, we have used a lot of Sun Valley theming, so I feel to go with GTK and Qt. Inching more towards Qt if it works everywhere.

@im-coder-lg
Copy link
Member

Wait, can you theme apps when you use PyQt?

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

afaik yeah

@Moosems
Copy link
Member Author

Moosems commented Jan 24, 2023

Wait, can you theme apps when you use PyQt?

With how popular it is I'd be surprised if you can't

@sumeshir26
Copy link
Member

@im-coder-lg Qt follows the system theme regardless of the system :)

@sumeshir26
Copy link
Member

And I found this if we want to have Sun Valley Theming: https://github.com/zhiyiYo/PyQt-Fluent-Widgets

@not-nef
Copy link
Member

not-nef commented Jan 24, 2023

YES THATS WHAT IVE BEEN LOOKING FOR TYSM

@im-coder-lg
Copy link
Member

yeah!

LESGOO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants