You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed something in Jenkiexs.Buids.details/2 but didn't want to change in the abovementioned PR because it's not its purpose.
Jenkiexs.Builds.details/2 uses Client.get!/3 as follows:
defdetails(job_name,build_number)docaseClient.get!("/job/#{job_name}/#{build_number}/api/json")do%{status_code: 200,body: body}->build=new(job_name,body){:ok,build}%{status_code: status,body: body}->{:error,"Got status #{status} with body #{inspect(body)}."}endend
What do you think about changing that request to Client.get/3 and then creating a Jenkiexs.Builds.details!/2 just to keep the API consistent?
I noticed something in
Jenkiexs.Buids.details/2
but didn't want to change in the abovementioned PR because it's not its purpose.Jenkiexs.Builds.details/2
usesClient.get!/3
as follows:What do you think about changing that request to
Client.get/3
and then creating aJenkiexs.Builds.details!/2
just to keep the API consistent?Originally posted by @dflima in #18 (comment)
The text was updated successfully, but these errors were encountered: