Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecation warning for remote references in JSONSchema validator :: datagov-harvesting-logic #4566

Open
1 task
btylerburton opened this issue Dec 19, 2023 · 0 comments
Labels
bug Software defect or bug H2.0/Harvest-Runner Harvest Source Processing for Harvesting 2.0

Comments

@btylerburton
Copy link
Contributor

This bug occurs when running tests in the datagov-harvesting-logic repository.

How to reproduce

  1. Install required dependencies
  2. Run tests, via make test

Expected behavior

Observe passing tests and no warning

Actual behavior

Observe warning about remote references that will soon become an error:

tests/validate/dcatus/test_dcat_us.py: 30 warnings
  /Users/brendantburton/Repos/datagov-harvesting-logic/.venv/lib/python3.10/site-packages/jsonschema/_keywords.py:295: 
DeprecationWarning: Automatically retrieving remote references can be a security vulnerability 
and is discouraged by the JSON Schema specifications. Relying on this behavior is deprecated 
and will shortly become an error. If you are sure you want to remotely retrieve your 
reference and that it is safe to do so, you can find instructions for doing so 
via referencing.Registry in the referencing documentation (https://referencing.readthedocs.org).
    yield from validator.descend(

Sketch

  • Follow documentation provided at https://referencing.readthedocs.org for how to remove this warning.
@btylerburton btylerburton added bug Software defect or bug H2.0/Validate labels Dec 19, 2023
@gujral-rei gujral-rei moved this to 📔 Product Backlog in data.gov team board Dec 21, 2023
@rshewitt rshewitt self-assigned this Jan 4, 2024
@rshewitt rshewitt moved this from 📔 Product Backlog to 🏗 In Progress [8] in data.gov team board Jan 4, 2024
@btylerburton btylerburton added H2.0/Harvest-Runner Harvest Source Processing for Harvesting 2.0 and removed H2.0/Validate labels Jan 10, 2024
@rshewitt rshewitt moved this from 🏗 In Progress [8] to 📔 Product Backlog in data.gov team board Jan 16, 2024
@rshewitt rshewitt removed their assignment Jan 16, 2024
@btylerburton btylerburton moved this from 📔 Product Backlog to 🧊 Icebox in data.gov team board Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software defect or bug H2.0/Harvest-Runner Harvest Source Processing for Harvesting 2.0
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

2 participants