Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the Emscripten-built samples in our documentation page #1394

Open
RiscadoA opened this issue Dec 1, 2024 · 0 comments
Open

Include the Emscripten-built samples in our documentation page #1394

RiscadoA opened this issue Dec 1, 2024 · 0 comments
Assignees
Labels
A-Meta B-CI Related to CI actions O-Web Related to Emscripten builds P-Urgent This issue is a big priority, and it would be good to close it ASAP
Milestone

Comments

@RiscadoA
Copy link
Member

RiscadoA commented Dec 1, 2024

Problem

The Emscripten action we currently have uploads the sample results as artifacts to be downloaded.
It isn't practical for reviewers to test those samples, although it should be easy.
Additionally, it would be cool to have the samples hosted in our website, alongside their docs.

Solution

We should investigate improving the web build CI to include the built samples in their documentation pages.
These samples should appear in both the PR doc previews and on the final website deployment.
We avoid code duplication on those two scenarios, if possible.

@RiscadoA RiscadoA added A-Meta B-CI Related to CI actions O-Web Related to Emscripten builds labels Dec 1, 2024
@RiscadoA RiscadoA added this to the 0.6 milestone Dec 1, 2024
@RiscadoA RiscadoA self-assigned this Dec 2, 2024
@Dageus Dageus self-assigned this Dec 2, 2024
@RiscadoA RiscadoA removed their assignment Dec 2, 2024
@RiscadoA RiscadoA added the P-Urgent This issue is a big priority, and it would be good to close it ASAP label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta B-CI Related to CI actions O-Web Related to Emscripten builds P-Urgent This issue is a big priority, and it would be good to close it ASAP
Projects
None yet
Development

No branches or pull requests

2 participants