You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Emscripten action we currently have uploads the sample results as artifacts to be downloaded.
It isn't practical for reviewers to test those samples, although it should be easy.
Additionally, it would be cool to have the samples hosted in our website, alongside their docs.
Solution
We should investigate improving the web build CI to include the built samples in their documentation pages.
These samples should appear in both the PR doc previews and on the final website deployment.
We avoid code duplication on those two scenarios, if possible.
The text was updated successfully, but these errors were encountered:
Problem
The Emscripten action we currently have uploads the sample results as artifacts to be downloaded.
It isn't practical for reviewers to test those samples, although it should be easy.
Additionally, it would be cool to have the samples hosted in our website, alongside their docs.
Solution
We should investigate improving the web build CI to include the built samples in their documentation pages.
These samples should appear in both the PR doc previews and on the final website deployment.
We avoid code duplication on those two scenarios, if possible.
The text was updated successfully, but these errors were encountered: