Add SSAO resolution scale #1424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Engine
B-Rendering
C-Optimization
P-Urgent
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
==========================================
- Coverage 53.42% 53.40% -0.03%
==========================================
Files 462 462
Lines 25854 25865 +11
Branches 2391 2392 +1
==========================================
Hits 13813 13813
- Misses 12041 12052 +11 ☔ View full report in Codecov by Sentry. |
tomas7770
requested review from
GalaxyCrush,
kuukitenshi and
Dageus
and removed request for
a team and
Dageus
|
@RiscadoA will only be able to review this PR in 3 days. |
|
@GalaxyCrush will only be able to review this PR in 3 days. |
|
@kuukitenshi will only be able to review this PR in 3 days. |
|
@RiscadoA will only be able to review this PR in 5 days. |
|
@GalaxyCrush will only be able to review this PR in 5 days. |
|
@kuukitenshi will only be able to review this PR in 3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a resolution scale value to the SSAO component to adjust the SSAO texture size. The default value of 0.5 provides a good quality with much better performance than full resolution (1.0).
Checklist