Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom WebRTC #607

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Use custom WebRTC #607

merged 12 commits into from
Dec 4, 2024

Conversation

testableapple
Copy link
Collaborator

No description provided.

@testableapple testableapple requested a review from a team as a code owner November 26, 2024 12:52
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 26, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.61 MB 7.61 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 9.85 MB +1190 KB 🔴

@testableapple testableapple mentioned this pull request Dec 4, 2024
Merged
martinmitrevski
martinmitrevski requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge this for now.

@testableapple testableapple enabled auto-merge (squash) December 4, 2024 13:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
126 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@testableapple testableapple merged commit 45f8ee2 into develop Dec 4, 2024
13 of 14 checks passed
@testableapple testableapple deleted the webrtc branch December 4, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

@ipavlidakis ipavlidakis ipavlidakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testableapple @Stream-SDK-Bot @ipavlidakis @martinmitrevski