Added epub support #154
Open
Added epub support #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GjjvdBurg kind nudge to get this moving |
GjjvdBurg
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks for this PR @cvanelteren! I've left a few comments with suggestions. The main suggestion is that EPUB support can be handled by the LocalFile provider by modifying the base class, which seems simpler. Let me know what you think and whether you're up for making those changes!
|
Will check the PR tomorrow again. I abstracted some code but the build seems to be failing; local epub files are pushed to the remarkable with the integrated code. |
|
Same tests pass on the main @GjjvdBurg ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can upload epubs to remarkable via the api. Fixes #144