Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DEM vcrs when subtracting DEMs #633

Open
adehecq opened this issue Nov 2, 2024 · 0 comments
Open

Check DEM vcrs when subtracting DEMs #633

adehecq opened this issue Nov 2, 2024 · 0 comments
Labels
enhancement Feature improvement or request

Comments

@adehecq
Copy link
Member

adehecq commented Nov 2, 2024

Just another thought as I'm going through the new doc.
To avoid frequent errors from users who difference two DEMs, then notice a large vertical bias and apply coregistration, one could maybe add a check during numpy operations on DEMs that the two VCRS are identical? This sounds easy, but maybe a bit annoying to implement, as one would need to overwrite the Raster's methods no?

Because the vcrs is not always defined, the way I see is:
if both vcrs are defined
if both vcrs are identical -> runs without message
if both vcrs are different -> raises an error with a message indicating how to change the vcrs
if not both vcrs are not defined -> raises a warning of missing information

@adehecq adehecq added the enhancement Feature improvement or request label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or request
Projects
None yet
Development

No branches or pull requests

1 participant