Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affine matrix decomposition function to extract translation, rotation and scaling consistently #638

Open
rhugonnet opened this issue Nov 7, 2024 · 0 comments
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request

Comments

@rhugonnet
Copy link
Member

In #502 we add functions to extract translations/rotations, but this only works for a rigid transformation.
For an affine, transformation, we need to decompose the scaling/shear too.
See for instance: https://math.stackexchange.com/questions/237369/given-this-transformation-matrix-how-do-i-decompose-it-into-translation-rotati

Additionally, having these functions as methods of AffineCoreg is not the most easy for manipulation (cannot use these methods to build matrixes for example in the documentation, or for the tests, for instance).
Should we have separate public functions in affine.py instead?

@rhugonnet rhugonnet added enhancement Feature improvement or request architecture Need to re-organize or re-structure something labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request
Projects
None yet
Development

No branches or pull requests

1 participant