Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Mod Hooks: Add right click - Create Script Hook #115

Open
KANAjetzt opened this issue Nov 29, 2024 · 1 comment
Open

[4.x] Mod Hooks: Add right click - Create Script Hook #115

KANAjetzt opened this issue Nov 29, 2024 · 1 comment
Labels

Comments

@KANAjetzt
Copy link
Member

The naming is open for debate πŸ˜…
With GodotModding/godot-mod-loader#440 hooks can now be written in separate files.

Ste β€” 16/11/2024 23:08
would we rather open a second tree for hooks potentially doubling the vanilla file system again? or would we rather enforce a naming convention and live with the fact that hooks technically aren't extensions

res://
β”œβ”€β”€ game/
β”‚   └── scripts/
β”‚       └── main.gd
└── mods-unpacked/
    └── some-mod/
        β”œβ”€β”€ extensions/
        β”‚   └── game/
        β”‚       └── scripts/
        β”‚           └── main.gd
        └── hooks/
            └── game/
                └── scripts/
                    └── main.gd

or

.
β”œβ”€β”€ game/
β”‚   └── scripts/
β”‚       └── main.gd
└── mods-unpacked/
    └── some-mod/
        └── extensions/
            └── game/
                └── scripts/
                    β”œβ”€β”€ main.gd
                    └── hooks-main.gd

We decided to go with the -hook.gd naming convention

@KANAjetzt KANAjetzt added the 4.x label Nov 29, 2024
@Qubus0
Copy link
Collaborator

Qubus0 commented Nov 29, 2024

gave it another thought, we could also go for main.hooks.gd, that seems the cleanest "meaning wise" to me. might be personal preference though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants