Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

DataflowPathValidator.verifyPathIsAccessible should throw checked exception, not runtime exception #586

Open
elharo opened this issue Jul 5, 2017 · 0 comments

Comments

@elharo
Copy link

elharo commented Jul 5, 2017

still digging into exactly why this happens, but meanwhile this should be a checked exception, probably some kind of IOException. This is an external condition, not a bug in the program itself. so an IllegalArgumentException is inappropriate.

Caused by: java.lang.IllegalArgumentException: Output path does not exist or is not writeable: gs://tester
	at com.google.cloud.dataflow.sdk.repackaged.com.google.common.base.Preconditions.checkArgument(Preconditions.java:146)
	at com.google.cloud.dataflow.sdk.util.DataflowPathValidator.verifyPathIsAccessible(DataflowPathValidator.java:80)
	at com.google.cloud.dataflow.sdk.util.DataflowPathValidator.validateOutputFilePrefixSupported(DataflowPathValidator.java:63)
	at com.google.cloud.dataflow.sdk.runners.DataflowPipelineRunner.fromOptions(DataflowPipelineRunner.java:274)
	at com.google.cloud.dataflow.sdk.runners.BlockingDataflowPipelineRunner.fromOptions(BlockingDataflowPipelineRunner.java:82)
	... 9 more
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant