-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snackbar 1104 #1109
base: master
Are you sure you want to change the base?
Fix snackbar 1104 #1109
Conversation
@@ -31,7 +31,7 @@ | |||
<string name="tree">tree</string> | |||
|
|||
<string name="sync_blocked" translatable="false">Sync Blocked</string> | |||
<string name="sync_started">Sync Started</string> | |||
<string name="sync_started">Sync Started, please wait</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the PR! However, I noticed that you added the phrase "Sync Started, please wait" in English to the strings.xml file, but did not provide translations for this addition in the other language files.
For consistency and to ensure a smooth user experience for non-English speakers, could you please add the corresponding translations for "Sync Started, please wait" in the other language files as well? This will help maintain the app's localization standards.
Thank you for your attention to this!
Best regards,
Hi @Tarek-Bohdima , I have added the required translations in pt and sw. Please verify. |
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
./codeAnalysis
to automatically apply formatting/linting)Fixes #1104
Current (issue) screenshot:
Fix screenshot: