Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snackbar 1104 #1109

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

gaurav133
Copy link
Contributor

@gaurav133 gaurav133 commented Feb 24, 2024

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Fixes #1104
Current (issue) screenshot:
Screenshot 2024-02-24 at 10 51 09 PM

Fix screenshot:

WhatsApp Image 2024-02-24 at 10 36 22 PM (1)
WhatsApp Image 2024-02-24 at 10 36 22 PM

@@ -31,7 +31,7 @@
<string name="tree">tree</string>

<string name="sync_blocked" translatable="false">Sync Blocked</string>
<string name="sync_started">Sync Started</string>
<string name="sync_started">Sync Started, please wait</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the PR! However, I noticed that you added the phrase "Sync Started, please wait" in English to the strings.xml file, but did not provide translations for this addition in the other language files.

For consistency and to ensure a smooth user experience for non-English speakers, could you please add the corresponding translations for "Sync Started, please wait" in the other language files as well? This will help maintain the app's localization standards.

Thank you for your attention to this!

Best regards,

@gaurav133
Copy link
Contributor Author

Hi @Tarek-Bohdima , I have added the required translations in pt and sw. Please verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sync Started" upload is on the bottom on green. Make it more visuable.
2 participants