Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend/Datanode use different command line to configure grpc addr #2571

Closed
evenyag opened this issue Oct 11, 2023 · 3 comments
Closed

Frontend/Datanode use different command line to configure grpc addr #2571

evenyag opened this issue Oct 11, 2023 · 3 comments
Assignees
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed

Comments

@evenyag
Copy link
Contributor

evenyag commented Oct 11, 2023

What type of enhancement is this?

User experience

What does the enhancement do?

Frontend uses grpc-addr

#[clap(long)]
grpc_addr: Option<String>,

Datanode uses rpc-addr

#[clap(long)]
rpc_addr: Option<String>,

Standalone uses rpc-addr

#[clap(long)]
rpc_addr: Option<String>,

Implementation challenges

No response

@evenyag evenyag added the C-enhancement Category Enhancements label Oct 11, 2023
@killme2008 killme2008 added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 12, 2023
@masonyc
Copy link
Contributor

masonyc commented Oct 13, 2023

Hi, I am interested in this change. Could you please assign this to me?

To clarify, goal is to rename all of them to grpc_addr? Would it make more sense to make it all starts with rpc_*? The underlying classes e.g DataNodeOptions got fields starts with rpc_*

@fengjiachun
Copy link
Collaborator

Hi @masonyc, I believe it would make more sense to unify them as rpc_*. cc @evenyag

@tisonkun
Copy link
Collaborator

tisonkun commented Nov 9, 2023

@fengjiachun we may close this issue as #2609 merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants