Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static user provider doesn't work for gRPC in v0.4.0 #2578

Closed
killme2008 opened this issue Oct 11, 2023 · 2 comments
Closed

static user provider doesn't work for gRPC in v0.4.0 #2578

killme2008 opened this issue Oct 11, 2023 · 2 comments
Assignees
Labels
C-bug Category Bugs
Milestone

Comments

@killme2008
Copy link
Contributor

killme2008 commented Oct 11, 2023

What type of bug is this?

Unexpected error

What subsystems are affected?

Other

What happened?

Start the standalone with static user provider:

cargo run -- standalone start --user-provider=static_user_provider:cmd:greptime_user=greptime_pwd

But the user_provider in gRPC handler is always None, looks like the bug is back again.

let user_info = auth(self.user_provider.clone(), header, &query_ctx).await?;

And our test doesn't cover this case at all.

What operating system did you use?

Ubuntu 22

Relevant log output and stack trace

No response

How can we reproduce the bug?

As described above.

@evenyag
Copy link
Contributor

evenyag commented Oct 16, 2023

@shuiyisong Can we close this PR now?

@shuiyisong
Copy link
Contributor

@evenyag Yes. We'll track adding tests in #2579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category Bugs
Projects
None yet
Development

No branches or pull requests

3 participants