Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readable form for all size and duration options in config file #2582

Closed
evenyag opened this issue Oct 12, 2023 · 1 comment
Closed

Use readable form for all size and duration options in config file #2582

evenyag opened this issue Oct 12, 2023 · 1 comment
Assignees
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed

Comments

@evenyag
Copy link
Contributor

evenyag commented Oct 12, 2023

What type of enhancement is this?

Configuration, User experience

What does the enhancement do?

There are still many options don't use ReadableSize and ReadableDuration.

grpc

// Max gRPC receiving(decoding) message size
pub max_recv_message_size: usize,
// Max gRPC sending(encoding) message size
pub max_send_message_size: usize,

heartbeat

pub struct HeartbeatOptions {
pub interval_millis: u64,
pub retry_interval_millis: u64,
}

meta client

pub struct MetaClientOptions {
pub metasrv_addrs: Vec<String>,
pub timeout_millis: u64,
#[serde(default = "default_heartbeat_timeout_millis")]
pub heartbeat_timeout_millis: u64,
#[serde(default = "default_ddl_timeout_millis")]
pub ddl_timeout_millis: u64,
pub connect_timeout_millis: u64,
pub tcp_nodelay: bool,
}

Implementation challenges

No response

@evenyag evenyag added the C-enhancement Category Enhancements label Oct 12, 2023
@killme2008 killme2008 added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 12, 2023
@masonyc
Copy link
Contributor

masonyc commented Oct 12, 2023

Hi, I would like to work on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants