Execute create database in procedure

[WenyXu]

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

Before implementing the drop database #825, we should move the create database execution into the procedure. It needs to require a schema-level lock before execution.

Implementation challenges

No response

[john8628]

can i have a try? @WenyXu

[WenyXu]

can i have a try? @WenyXu

Thanks ❤️

[john8628]

@WenyXu I think I need some help for working on adding support for a new CreateDatabaseProcedure by:

1. Adding a new variant CreateDatabase(CreateDatabaseTask) to the ddlTask enum
2. Implementing CreateDatabaseTask in ddl.rs
3. Implementing submit_create_database_task async function in ddl_taskmanager
   However, when running the project I'm getting the following error:
   error[E0432]: unresolved import api::v1::meta::CreateDatabaseTask
   --> src/common/meta/src/rpc/ddl.rs:22:5
   |
   22 | CreateDatabaseTask as PbCreateDatabaseTask
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | no CreateDatabaseTask in v1::meta
   | help: a similar name exists in the module: CreateTableTask

[WenyXu]

@WenyXu I think I need some help for working on adding support for a new CreateDatabaseProcedure by:

1. Adding a new variant CreateDatabase(CreateDatabaseTask) to the ddlTask enum
2. Implementing CreateDatabaseTask in ddl.rs
3. Implementing submit_create_database_task async function in ddl_taskmanager
   However, when running the project I'm getting the following error:
   error[E0432]: unresolved import api::v1::meta::CreateDatabaseTask
   --> src/common/meta/src/rpc/ddl.rs:22:5
   |
   22 | CreateDatabaseTask as PbCreateDatabaseTask
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | no CreateDatabaseTask in v1::meta
   | help: a similar name exists in the module: CreateTableTask

You need to define the it in this repo

[john8628]

OK ,got it , thanks

[WenyXu]

Hi @john8628, How is it going? Do you have any updates?

[john8628]

you have any updates

I am sorry, it seems difficult to me; I cannot do it alone.

[WenyXu]

you have any updates

I am sorry, it seems difficult to me; I cannot do it alone.

It's fine. Maybe take a look at other good first issues.

[john8628]

you have any updates

I am sorry, it seems difficult to me; I cannot do it alone.

It's fine. Maybe take a look at other good first issues.

thanks

[QuenKar]

hi! is there someone solving the issue? can I have a try?

[fengjiachun]

Close this issue, the detail in this comment: #2880 (comment)