Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the behaviors in KvBackend implements #2616

Closed
2 tasks done
WenyXu opened this issue Oct 18, 2023 · 0 comments · Fixed by #2615
Closed
2 tasks done

Correct the behaviors in KvBackend implements #2616

WenyXu opened this issue Oct 18, 2023 · 0 comments · Fixed by #2615
Labels
C-enhancement Category Enhancements

Comments

@WenyXu
Copy link
Member

WenyXu commented Oct 18, 2023 •
edited by fengjiachun
Loading

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

The MemoryKvBackend and RaftEngineBackend don't correctly handle the range & delete_range.

The KvBackend trait requires:

  • If range_end is '\0', the range is all keys >= key.
  • If both key and range_end are '\0', then the range request returns all.

Steps

Implementation challenges

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category Enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct the range behavior in MemoryKvBackend & RaftEngineBackend WenyXu/greptimedb
1 participant
@WenyXu