fix: schema validation is skipped once we need to fill a column #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2548 +/- ##
===========================================
- Coverage 85.34% 85.02% -0.33%
===========================================
Files 737 737
Lines 117409 117734 +325
===========================================
- Hits 100206 100106 -100
- Misses 17203 17628 +425 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…timeTeam#2548) * test: test different order * test: add tests for missing and invalid columns * fix: do not skip schema validation while missing columns * chore: use field_columns() * test: add tests for different column order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR fixes an issue that
WriteRequest::check_schema()doesn't check the schema of remaining columns inrowsif it finds out that a column is absent but has a default value.It uses a flag to store whether rows have such a column instead of returning directly.
It also adds some tests for input rows with different column order than the region.
Checklist
Refer to a related PR or issue link (optional)
fixes #2547