Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning Thershold Value is used as Critical Value #2

Open
HardTy opened this issue Aug 2, 2018 · 0 comments
Open

Warning Thershold Value is used as Critical Value #2

HardTy opened this issue Aug 2, 2018 · 0 comments

Comments

@HardTy
Copy link

HardTy commented Aug 2, 2018

Hi,
At the following line:

check_prometheus/mode/targetsHealth.go

Line 100 in 6b57581

state := check_x.Evaluator{Warning: warn, Critical: warn}.Evaluate(healthRate)

you use the warn value for Warning and Critical. That looks wrong.
If I use the check I get all the time a critical state and no warning state.
Regards,
René
@HardTy HardTy mentioned this issue Aug 2, 2018
Closed
ulikl added a commit to ConSol-Monitoring/check_prometheus that referenced this issue Jan 14, 2020
@ulikl
fixes for
fb04bb9 
- Griesbacher#2 Warning Thershold Value is used as Critical Value
  also for queries
ulikl added a commit to ConSol-Monitoring/check_prometheus that referenced this issue Jan 14, 2020
@ulikl
fixes for
b5b4257 
- Issue Griesbacher#2 Warning Thershold Value is used as Critical Value
  also for queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HardTy