Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD_TESTS does nothing #20

Open
orbea opened this issue Jan 13, 2024 · 2 comments
Open

BUILD_TESTS does nothing #20

orbea opened this issue Jan 13, 2024 · 2 comments

Comments

@orbea
Copy link
Contributor

orbea commented Jan 13, 2024

In commit 5bc418e the appdata files were removed, but the BUILD_TESTS cmake option remained.

if(BUILD_TESTS)
# add 'make test' target, use 'make test ARGS="-V"' or 'ctest -V' for verbose
enable_testing()
endif(BUILD_TESTS)

It now does nothing since the appdata files are gone, what was the intent here? Are different tests going to be created in the future? Should BUILD_TESTS be removed altogether? Should the appdata files be restored? I don't have a personal preference here.

@orbea
Copy link
Contributor Author

orbea commented Feb 26, 2024

@Grumbel I would really appreciate your input here.

@Apteryks
Copy link

Indeed, I also get: "No tests were found!!!" when running 'make check'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants