Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new subsection "Important: public information" at the end of step 3 #96

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add new subsection "Important: public information" at the end of step 3 #96

wants to merge 3 commits into from

Conversation

pcraig3
Copy link
Collaborator

@pcraig3 pcraig3 commented Dec 10, 2024 •
edited
Loading

Summary

This PR adds a new subsection to the end of step 3 with the following text:

Important: public information

When filling out your SF-424 form, pay attention to Box 15: Descriptive Title of Applicant's Project.

We share what you put there with [USAspending](https://www.usaspending.gov/). This is where the public goes to learn how the federal government spends their money.

Instead of just a title, insert a short description of your project and what it will do.

This will be added to the end of any section named "Step 3: Prepare Your Application" or Step 3: Write Your Application".

Once this goes in, it will be added to every uploaded NOFO from now on. This is what we want, right, @admoorgit?

screenshot

editing view html view
this new section in the editing view new section in the HTML view
Screenshot 2024-12-10 at 10 33 20 AM Screenshot 2024-12-10 at 10 34 03 AM

Merging this PR closes #88

@pcraig3
Add a new NOFO subsection to all imported NOFOs
1ee5a2c 
This is the first time we are doing something like this.

A few things to note:

- We have added extra content to a NOFO before, but that has been
  done via the template, nofo_view.html (eg, before you begin page)
- The 'body' of the added subsection can either by HTML or it can be
  a markdown string. I've opted for the latter as it is more readable.
@pcraig3
Add tests for the new add_subsection function
cafc98d 
The tests make sure that the new subsection is added to step 3 only.

If we don't find a subsection with the name we expect, we don't add
the subsection.
@pcraig3
Add docstring to add_final_subsection_to_step_3 function
75812d9
@pcraig3 pcraig3 requested a review from admoorgit December 10, 2024 15:49
@pcraig3 pcraig3 requested a review from jtmst December 10, 2024 18:01
jtmst
jtmst approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@jtmst jtmst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmst jtmst jtmst approved these changes

@admoorgit admoorgit Awaiting requested review from admoorgit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add required text at the end of Section 3
3 participants
@pcraig3 @jtmst @admoorgit