Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement better testing and against multiple NumPy versions #630

Open
agriyakhetarpal opened this issue Aug 23, 2024 · 0 comments
Open

Implement better testing and against multiple NumPy versions #630

agriyakhetarpal opened this issue Aug 23, 2024 · 0 comments
Milestone
v1.8.0

Comments

@agriyakhetarpal
Copy link
Collaborator

  • Testing with both NumPy v1.X and NumPy v2.X until NumPy v1 is obsolete
  • [ci] Run test workflow at the beginning of every month and enable manual trigger of the pipeline. #629 is going to add a schedule to the tests, extend the tests against NumPy and SciPy nightlies there (or in another workflow)
  • Implement an upper bound on NumPy according to the NumPy guidelines
  • Establish a 1.X lower-bound for our dependence on NumPy, i.e., find the minimum value of X where all tests pass and keep bumping it with every release

Notes to refer to, cross-posted from #628 (comment):

  1. NumPy development docs
  2. Package indices to grab nightly wheels from for NumPy and SciPy
@agriyakhetarpal agriyakhetarpal mentioned this issue Aug 24, 2024
Merged
agriyakhetarpal added a commit that referenced this issue Sep 25, 2024
@agriyakhetarpal
feat: migrate to nox, run tests in parallel, revamp test infra (#632)
7fb2426 
Closes #631, and related to #630.
@agriyakhetarpal agriyakhetarpal mentioned this issue Sep 25, 2024
Merged
@agriyakhetarpal agriyakhetarpal added this to the v1.8.0 milestone Oct 15, 2024
agriyakhetarpal added a commit that referenced this issue Dec 2, 2024
@agriyakhetarpal
Fix scipy.special.logsumexp type promotion, test against NumPy and …
b204c2f 
…SciPy nightlies (#643)

This PR enables testing against NumPy and SciPy nightlies, which were
added in #632 and later disabled to be split out here. I've also fixed a
test relating to incorrect shapes being cast (scalars were not being
treated as arrays) within the `combo_check` function, so all tests
should now pass on nightly and stable versions.

Related to #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
1 participant
@agriyakhetarpal