Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renumber metrics #151

Open
jmellorcrummey opened this issue Dec 29, 2021 · 1 comment
Open

renumber metrics #151

jmellorcrummey opened this issue Dec 29, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone
Release 2022.09

Comments

@jmellorcrummey
Copy link
Member

the last time that i checked, hpcviewer used a sparse set of (sometimes) large numbers for metric indices. it should not present such numbers. if such numbers arise (perhaps while computing metrics in the viewer), we should build a bi-directional map from internal sparse metric indices to a set of dense small indices. a hash table can be used for the sparse to dense mapping. an array can map back to internal sparse metric indices if necessary.
@laksono laksono added the enhancement New feature or request label Jan 14, 2022
@laksono laksono added this to the Release 2022.04 milestone Jan 16, 2022
laksono added a commit that referenced this issue Feb 1, 2022
@laksono
Draft fix issue #151 (renumbering metric index)
2342ed5 
To support backward compatibility, it's much simpler to renumbering the
metric index inside the derived metric window instead of in the
beginning.
If we renumber in the beginning, we'll have a headache with storing the
formula as the metric index will differ from experiment.xml to the
stored one.

This may not be an issue in prof2 since we don't have metric id. But
since we need to keep backward compatibility, we should make changes
with minimal effects.
laksono added a commit that referenced this issue Feb 1, 2022
@laksono
Feature prof2 (#174)
4170010 
* Code clean up, remove dead codes
* Fix issue #168 (incorrect metric when merging stat metrics)
* Fix build.yml to include develop branch
* Generalize database parser for v2 and v4

Add DataMeta to parse database v4 (from prof).

* Change the API to open a database: use File instead of String
* Rename maven groupId to edu.rice.cs.hpcviewer from e.r.hpcviewer
* refine unit test for Experiment class
* print the error message instead of the stack trace
* Fix security hotspot and other issues reported by sonar
* Standardize the comments
* Derived metric window with content assist

* Draft fix issue #151 (renumbering metric index)
To support backward compatibility, it's much simpler to renumbering the
metric index inside the derived metric window instead of in the
beginning.
If we renumber in the beginning, we'll have a headache with storing the
formula as the metric index will differ from experiment.xml to the
stored one.

This may not be an issue in prof2 since we don't have metric id. But
since we need to keep backward compatibility, we should make changes
with minimal effects.

* Refine the test
* Minor Fixes to conform with Java compliant
@blue42u
Copy link
Contributor

blue42u commented Aug 18, 2022

This repository has moved to GitLab, please continue this issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 2022.09
Development

No branches or pull requests
3 participants
@jmellorcrummey @laksono @blue42u