Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate icon sets for dark GTK themes #219

Open
wyphan opened this issue Jun 14, 2022 · 1 comment
Open

Alternate icon sets for dark GTK themes #219

wyphan opened this issue Jun 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@wyphan
Copy link

wyphan commented Jun 14, 2022 •
edited
Loading

Describe the feature
It would be nice if hpcviewer provides icons for buttons that are visible with GTK dark themes.
Currently it assumes a light background for the GTK window, so some of the buttons are barely visible or not contrasting enough with a dark background.
Screenshot from 2022-06-14 13-13-29
Screenshot from 2022-06-14 13-55-31

Additional context
This will require producing a second icon set that is adjusted for a dark background, and a toggle switch in "Preferences" to choose the icon set accordingly.
Possibly related with #181
@wyphan wyphan added the enhancement New feature or request label Jun 14, 2022
@blue42u
Copy link
Contributor

blue42u commented Aug 18, 2022

This repository has moved to GitLab, please continue this issue there.

jmellorcrummey pushed a commit that referenced this issue Jul 28, 2023
@laksono
Merge branch 'release-2023.07' into 'main'
6c44510 
Release 2023.07: fix issue #331, fix dark theme, remove unused classes

Closes #219, #134, and #331

See merge request hpctoolkit/hpcviewer!302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blue42u @wyphan