Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread-centric view needs work #221

Open
jmellorcrummey opened this issue Jun 15, 2022 · 2 comments
Open

Thread-centric view needs work #221

jmellorcrummey opened this issue Jun 15, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
Release 2022.09

Comments

@jmellorcrummey
Copy link
Member

jmellorcrummey commented Jun 15, 2022 •
edited
Loading

Describe the feature

  • eliminate option to graph metrics that are hidden or zero
  • improve rendering of title for plot graph
    • cope with long function names
    • cope with GPU streams
  • improve rendering of entities on X axis
    • spacing
    • labels
  • height of menu for selecting what to plot should be same as height of the hpcviewer window

Additional context
Screenshot that illustrates issues with title and rendering of entities on X axis

image

Issue with metric selection menu

image
@jmellorcrummey jmellorcrummey added the enhancement New feature or request label Jun 15, 2022
@laksono laksono added this to the Release 2022.09 milestone Jun 15, 2022
@laksono
Copy link
Member

laksono commented Jun 15, 2022

  • The list of metrics requires some filtering. This can be done easily since we already have an API for this purpose.
  • The swtchart library to plot the graph is very old, we need to upgrade it to the latest version which requires other libraries and some changes in API. This may require some significant time.
  • What kind of improvements needed for the X axis? I can understand for the label, but not sure for the spacing.
  • Height of the menu: Since the menu is platform-dependent, we can replace it by using a wizard dialog so we have more controls.
    • Question: Do you think we will need to plot multiple metrics at the same plot graph? Currently we only plot for one context and one metric (since it's the easiest). But sometimes I need to plot different metrics into one graph.

laksono added a commit that referenced this issue Jul 7, 2022
@laksono
fix issue #221: non-empty metrics only in graph menu
963dc0d 
Only display non-empty metrics instead of all metrics in the context
menu for plot graphs.
The difficulty is because there is no correlation between general
metrics in metric table and metrics in metric-db. The viewer is forced
to correlate manually by matching the name.

This is not a major issue in meta.db since it has consistent metric ids
for all meta.db, profile.db and cct.db
@blue42u
Copy link
Contributor

blue42u commented Aug 18, 2022

This repository has moved to GitLab, please continue this issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 2022.09
Development

No branches or pull requests
3 participants
@jmellorcrummey @laksono @blue42u