Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The call stack pane doesn't account for descenders #226

Open
jmellorcrummey opened this issue Jul 13, 2022 · 2 comments
Open

The call stack pane doesn't account for descenders #226

jmellorcrummey opened this issue Jul 13, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jmellorcrummey
Copy link
Member

Describe the bug
When the font size is increased, letters with descenders below the baseline, e.g. "p", "q", get the part below the baseline clipped

To Reproduce
Increase the font size several times in the profile pane. Then look at the call stack view in the trace pane.

Expected behavior
Letters should not be clipped if the font size is increased.

Screenshots
This first screen shot is OK.
image
After increasing the font size, see how the letters are clipped in the call stack.
image

Platform (please complete the following information):

  • OS: MacOS
  • Architecture x86
  • Version 2022.06
@jmellorcrummey jmellorcrummey added the bug Something isn't working label Jul 13, 2022
@laksono
Copy link
Member

laksono commented Jul 13, 2022

This happens because the call stack view is based on SWT table. Resizing the row's height automatically is not easy in SWT and the behavior is different from GTK to MacOS.
The easiest way is to convert to NatTable where we have the control to resize the row's height just like the statistic table.

@laksono laksono self-assigned this Jul 13, 2022
@blue42u
Copy link
Contributor

blue42u commented Aug 18, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants