Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medigoron not properly resetting Broken Giant's Knife flag #4601

Open
ScorelessPine opened this issue Nov 30, 2024 · 4 comments · May be fixed by #4608
Open

Medigoron not properly resetting Broken Giant's Knife flag #4601

ScorelessPine opened this issue Nov 30, 2024 · 4 comments · May be fixed by #4608

Comments

@ScorelessPine
Copy link

8mb.video-j2H-MxxNL5lC.mp4

When the player has Giant's Knife and breaks it, the flag for "Goron's Sword (Broken)" is set in the inventory, but when purchasing a new Giant's Knife from Medigoron, this flag is supposed to become unset but it never seems to do so. This can also affect the B button sprite of Biggoron's Sword to appear as if it is broken permanently. This may also cause another issue, if you break a Giant's Knife (setting the flag to Broken), buy a new one from Medigoron, and break that one, the flag becomes flipped again back to fixed, however the sword is still broken, and Medigoron no longer sells you a new one because he thinks the sword is not broken.
@Gameboy9917
Copy link

Relevant information:

This is not a ship-specific bug, this same behavior has been tested and proven on console. Repairing Giant's Knife after you break it without both Kokiri Sword and Master Sword in the inventory will not flip the "broken" flag, but it will restore the knife's health. Breaking it again will flip the flag to "not broken" and will no longer allow you to repair it.

Perhaps make it an optional fix in the Enhancements tab?

@JordanLongstaff JordanLongstaff linked a pull request Dec 2, 2024 that will close this issue
Open
@JordanLongstaff
Copy link
Contributor

How do you not have both the Kokiri Sword and Master Sword?

@ScorelessPine
Copy link
Author

How do you not have both the Kokiri Sword and Master Sword?

This issue affects randomizer, where both Kokiri Sword and Master Sword can be shuffled, so if Giant's Knife is found before both of those, this issue can be noticed. Also obviously this could happen in a vanilla playthrough if the player escapes the forest to skip Kokiri Sword.

@Pepper0ni
Copy link
Contributor

Pepper0ni commented Dec 3, 2024 •
edited
Loading

How do you not have both the Kokiri Sword and Master Sword?

Forest escape into DoT skip or glitching past mido in kokiri forest lets you skip Ksword in vanilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Broken Giant's Knife flag not resetting JordanLongstaff/Shipwright
4 participants
@JordanLongstaff @ScorelessPine @Gameboy9917 @Pepper0ni