Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending approvals list is empty after assigning a scope before approving the subscription #227

Open
fromanu opened this issue Oct 7, 2019 · 3 comments
Assignees

Comments

@fromanu
Copy link

fromanu commented Oct 7, 2019

If there is a new subscription approval pending, the admin can assign a scope to the subscription before or after approving it:

  • In case the admin approves the subscription and after that assigns a scope, everything works as expected.
  • In case the admin decides to assign a scope at first and then to approve the subscription, there is a problem: the subscription disappears from the list of Pending Subscription Approvals and cannot be approved anymore.
@DonMartin76
Copy link
Member

Can you please have a loot at this @santokhsingh?

@santokhsingh
Copy link
Collaborator

ok, will check

@MibenCoop
Copy link
Contributor

@DonMartin76 The problem is that In both cases, one method is used ( in wicked.api ): changing the scope and approving subscriptions. Therefore, at the end of this method, the subscription is removed from the approvals list in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants